1295962 - Remove tc prefix from lint jobs

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Andrew Halberstadt [:ahal]]

I don't like the 'tc' group name convention. I can understand it for platforms where we have a mix of buildbot/taskcluster jobs, but for platforms that are 100% taskcluster, the prefix is unnecessary and results in more cargo culting. The 'lint opt' platform is one of these.

Comment 1

[Andrew Halberstadt [:ahal]]

For some reason the patch in this try run (changing 'tc' to '?') didn't work:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=296abff68f5db3e9e24065806ef74cde49abaa31

Removing groupSymbol altogether also didn't work. Dustin, do you know how to remove the tc groupSymbol?

Comment 2

[Greg Arndt [:garndt]]

Cameron, it appears that this job has the group symbol "?" but it still appears in the tc group.  Do you know what the default behavior is for that group symbol and how to get a job to not be in the tc() grouping?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=296abff68f5db3e9e24065806ef74cde49abaa31&selectedJob=25876541

Comment 3

[Gregory Szorc [:gps]]

Speaking of cargo culting, I added the Sphinx documentation job to the "lint opt" platform because I didn't want to add a new row to Treeherder. There are jobs most definitely not associated with any single platform (including Sphinx and lint). I'm not sure if we should rename the whole thing "misc" for now until we have enough tasks to split into multiple rows or what.

(There will also be tasks for `mach bootstrap` which don't fit well in any platform.)

Comment 4

[Andrew Halberstadt [:ahal]]

Yeah, I think it was jgraham who suggested we call it 'source' or something similar.. i.e jobs that just need a source checkout but aren't tied to any particular build or platform. If we make that change, I would modify the groupSymbol for these to be 'lint' instead of 'tc'.

I previously filed bug 1291689, we can rename the title there if people agree.

Comment 5

[Cameron Dawson [:camd]]

Looking into how the "tc" prefix is added now...  

But fwiw, it's also possible to filter on "build system" in the UI.  Go into Filters drop-down and add a new field filter for "build system" value: "taskcluster".  Then you'll only see taskcluster jobs.  Same deal for "buildbot"

The url will end up something like this: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-build_system_type=taskcluster

Comment 6

[Cameron Dawson [:camd]]

Unfortunately, this is yet another example of hitting bug 1215587.  I can fix this occurance in the DB, but we really need to address that bug.  I have a few things on my plate first, but will try to hit that as soon as I can.

Comment 7

[Cameron Dawson [:camd]]

I have fixed those job_types so they won't be in the "tc" group any longer.  But it sounds like we may want to  move more of them out.  Of course, if we can get to fixing bug 1215587, then it'll take whatever group you set in your tasks.  I will try to get to that soon-ish.  But I can't even promise this quarter, tbh.  I have several items in line before it..  :(

Comment 8

[Andrew Halberstadt [:ahal]]

Thanks Cam!

I clarified on irc that this happens when you change a job's groupSymbol (treeherder doesn't re-read the value from configs after saving it to the db). So Cam updated the value in the db, i.e the groupSymbol change is already live. I still need to land the config changes though, otherwise the groupSymbol will revert back when bug 1215587 gets fixed.

Comment 9

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1295962 - Remove 'tc' groupSymbol for tasks on the 'lint opt' platform,

Review commit: https://reviewboard.mozilla.org/r/72346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72346/

Comment 10

[Greg Arndt [:garndt]]

Comment on attachment 8782101 [details]
Bug 1295962 - Remove 'tc' groupSymbol for tasks on the 'lint opt' platform,

https://reviewboard.mozilla.org/r/72346/#review69954

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8af9d2ff421
Remove 'tc' groupSymbol for tasks on the 'lint opt' platform, r=garndt

Comment 12

[Andrew Halberstadt [:ahal]]

Actually, it looks like just the wpt lint jobs had the 'tc' symbol removed:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d8af9d2ff42176357eea8922ff7fe9ec82459d65

Cam, would you mind also updating the ES, MH and f8 jobs as well? Or I guess I can just wait for bug 1215587 too.

Comment 13

[Dustin J. Mitchell [:dustin] (he/him)]

If I recall, Armen had some good reasons for the "tc-" prefix.

As for platforms, those checks are mostly now in the "source-checks" kind in my work on bug 1286075 (egads I wish I had more time to spend on that..!!), so that might be a good name for the platform.  In general, platforms are a mess, but I'd like to defer work on that until bug 1286086.  Adding a "source-check" platform now is fine, but fixing the world will conflict substantially with bug 1286075.

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d8af9d2ff421

Comment 15

[Cameron Dawson [:camd]]

Looks like this is closed out now.  If you can wait, that'd be awesome.  I'll try to get to that bug before very long.

Comment 16

[Armen [:armenzg]]

If I did have a preference for it I can't think of why it would be important.

Comment 17

[Andrew Halberstadt [:ahal]]

(In reply to Cameron Dawson [:camd] from comment #15)
> Looks like this is closed out now.  If you can wait, that'd be awesome. 
> I'll try to get to that bug before very long.

Sure, we can wait. No worries.


(In reply to Armen Zambrano [:armenzg] (EDT/UTC-4) from comment #16)
> If I did have a preference for it I can't think of why it would be important.

I think it's important if we're running the same job both with buildbot and taskcluster side by side (i.e while initially standing them up). But as long as the job is *only* being run with taskcluster on the given platform, I don't think it adds much value.

Comment 18

[Cameron Dawson [:camd]]

We can reopen this bug now.  The bug preventing it from working has been fixed now.  Is this something you'd still like to do?

Comment 19

[Andrew Halberstadt [:ahal]]

This bug was just for the lint jobs, and it did get fixed already. I think you meant to comment on bug 1386857. But also yes, I'd love if the tc prefixes were removed in general :)