1296172 - Make VectorImage's interaction with the surface cache cleaner

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

This bug is just meant to salvage the improvements made to VectorImage in bug 1289628 part 1c, since that bug was permanently backed out, but I think we still want those improvements.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Make VectorImage's interaction with the surface cache cleaner.

Here's the patch. You already reviewed this in its previous form in bug 1289628.
This version is rebased against bug 1296147. I figured it was worth a re-review
given its new context.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Try job here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=af7a270ebd40

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8782278 [details] [diff] [review]
Make VectorImage's interaction with the surface cache cleaner.

Review of attachment 8782278 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with whitespace nit fixed:

::: image/VectorImage.h
@@ +81,5 @@
> +private:
> +  /// Attempt to find a cached surface matching @aParams in the SurfaceCache.
> +  already_AddRefed<gfxDrawable>
> +    LookupCachedSurface(const SVGDrawingParameters& aParams);
> + 

Drop whitespace on blank line here.

Comment 4

[Seth Fowler [:seth] [:s2h]]

Attachment: Make VectorImage's interaction with the surface cache cleaner.

Thanks for the review! I've removed the unnecessary whitespace.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7203b2bd9c9
Make VectorImage's interaction with the surface cache cleaner. r=dholbert

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d7203b2bd9c9