1296185 - [Pointer Event] Import new web-platform-tests to pointer events mochitest

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Ming-Chou Shih [:stone]]

Added
pointerevent_attributes_mouse-manual.html
pointerevent_multiple_primary_pointers_boundary_events-manual.html
pointerevent_pointerId_scope-manual.html
pointerevent_pointermove-on-chorded-mouse-button.html
pointerevent_suppress_compat_events_on_click.html
pointerevent_suppress_compat_events_on_drag_mouse.html

Removed
pointerevent_button_attribute_mouse-manual.html

Comment 2

[Ming-Chou Shih [:stone]]

Attachment: [Pointer Event] Add new web-platform-tests to pointer events mochitest

Comment 3

[Ming-Chou Shih [:stone]]

Note. This is only import and wrap wpt tests as mochitests. I will submit another bugs to track the disabled test cases.

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8782322 [details] [diff] [review]
[Pointer Event] Add new web-platform-tests to pointer events mochitest

Review of attachment 8782322 [details] [diff] [review]:
-----------------------------------------------------------------

Please update the description and the bug title from "Add" to "Import" since this are just regular/periodic import of wpt to mochitest for pointer events.

Comment 5

[Bevis Tseng[:bevis][:btseng](Exited)]

> Please update the description
                   ^ patch

Comment 6

[Ming-Chou Shih [:stone]]

Attachment: [Pointer Event] Import new web-platform-tests to pointer events mochitest. (V2)

Comment 7

[Ming-Chou Shih [:stone]]

Updated modified test cases in part2. Some test cases are disabled because the modified tests are failed on current implementation. Will submit other bugs to track and fix them.

test_pointerevent_setpointercapture_inactive_button_mouse-manual.html
Current mochitest wrapper sends events to target1 while the test case removes div id="target1" and causes failure.

test_pointerevent_pointerup-manual.html
Updated helper js script adds checking of event.details and causes failure of this test.

test_pointerevent_pointerdown-manual.html
Updated helper js script adds checking of event.details and causes failure of this test.

test_pointerevent_constructor.html
Updated test adds checking of event.width = 1 and cause test failed
Updated test adds checking of event.height = 1 and cause test failed

Comment 8

[Ming-Chou Shih [:stone]]

Attachment: Part1: Import new web-platform-tests to pointer events mochitest. (V3)

Comment 9

[Ming-Chou Shih [:stone]]

Attachment: Part2: Update modified test cases (V3)

Comment 10

[Ming-Chou Shih [:stone]]

Updated the original v2 patch's summary as part1. Added part2 patch.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8782817 [details] [diff] [review]
Part1: Import new web-platform-tests to pointer events mochitest. (V3)

rs+

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8782819 [details] [diff] [review]
Part2: Update modified test cases (V3)

rs+ (rubberstamp) to this one too

Comment 13

[Ming-Chou Shih [:stone]]

Attachment: Part1: Import new web-platform-tests to pointer events mochitest.

Updated the patch summary.

Comment 14

[Ming-Chou Shih [:stone]]

Attachment: Part2: Update modified test cases

Updated the patch summary.

Comment 15

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a28264c4ebe09ee2f21158dcc9078dcc33c97a02

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c09313cf63cf
Part 1: [Pointer Event] Import new web-platform-tests to pointer events mochitest. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a2b51434497
Part 2: Update modified test cases. r=smaug

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c09313cf63cf
https://hg.mozilla.org/mozilla-central/rev/5a2b51434497