Closed Bug 1296185 Opened 4 years ago Closed 4 years ago

[Pointer Event] Import new web-platform-tests to pointer events mochitest

Categories

(Core :: DOM: Events, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: stone, Assigned: stone)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files, 4 obsolete files)

No description provided.
Summary: [Pointer Event] Add new web-platform-tests to mochitest → [Pointer Event] Add new web-platform-tests to pointer events mochitest
Added
pointerevent_attributes_mouse-manual.html
pointerevent_multiple_primary_pointers_boundary_events-manual.html
pointerevent_pointerId_scope-manual.html
pointerevent_pointermove-on-chorded-mouse-button.html
pointerevent_suppress_compat_events_on_click.html
pointerevent_suppress_compat_events_on_drag_mouse.html

Removed
pointerevent_button_attribute_mouse-manual.html
Assignee: nobody → sshih
Note. This is only import and wrap wpt tests as mochitests. I will submit another bugs to track the disabled test cases.
Comment on attachment 8782322 [details] [diff] [review]
[Pointer Event] Add new web-platform-tests to pointer events mochitest

Review of attachment 8782322 [details] [diff] [review]:
-----------------------------------------------------------------

Please update the description and the bug title from "Add" to "Import" since this are just regular/periodic import of wpt to mochitest for pointer events.
Attachment #8782322 - Flags: feedback?(btseng) → feedback+
> Please update the description
                   ^ patch
Summary: [Pointer Event] Add new web-platform-tests to pointer events mochitest → [Pointer Event] Import new web-platform-tests to pointer events mochitest
Attachment #8782384 - Flags: review?(bugs)
Blocks: 1296491
Blocks: 1296492
Blocks: 1296493
Blocks: 1296494
Blocks: 1296495
Blocks: 1296496
Keywords: meta
Keywords: meta
Attachment #8782384 - Flags: review?(bugs)
Updated modified test cases in part2. Some test cases are disabled because the modified tests are failed on current implementation. Will submit other bugs to track and fix them.

test_pointerevent_setpointercapture_inactive_button_mouse-manual.html
Current mochitest wrapper sends events to target1 while the test case removes div id="target1" and causes failure.

test_pointerevent_pointerup-manual.html
Updated helper js script adds checking of event.details and causes failure of this test.

test_pointerevent_pointerdown-manual.html
Updated helper js script adds checking of event.details and causes failure of this test.

test_pointerevent_constructor.html
Updated test adds checking of event.width = 1 and cause test failed
Updated test adds checking of event.height = 1 and cause test failed
Updated the original v2 patch's summary as part1. Added part2 patch.
Attachment #8782819 - Flags: feedback?(btseng)
Attachment #8782817 - Flags: feedback+
Attachment #8782819 - Flags: feedback?(btseng) → feedback+
Attachment #8782817 - Flags: review?(bugs)
Attachment #8782819 - Flags: review?(bugs)
Comment on attachment 8782817 [details] [diff] [review]
Part1: Import new web-platform-tests to pointer events mochitest. (V3)

rs+
Attachment #8782817 - Flags: review?(bugs) → review+
Comment on attachment 8782819 [details] [diff] [review]
Part2: Update modified test cases (V3)

rs+ (rubberstamp) to this one too
Attachment #8782819 - Flags: review?(bugs) → review+
Updated the patch summary.
Attachment #8782817 - Attachment is obsolete: true
Attachment #8783369 - Flags: review+
Updated the patch summary.
Attachment #8782819 - Attachment is obsolete: true
Attachment #8783370 - Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c09313cf63cf
Part 1: [Pointer Event] Import new web-platform-tests to pointer events mochitest. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a2b51434497
Part 2: Update modified test cases. r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c09313cf63cf
https://hg.mozilla.org/mozilla-central/rev/5a2b51434497
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.