Closed
Bug 1296253
Opened 8 years ago
Closed 8 years ago
Horizontal space for notes in the address book makes phone numbers unreadable
Categories
(Thunderbird :: Address Book, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 51.0
People
(Reporter: astrafo, Assigned: Paenglab)
References
Details
Attachments
(2 files, 1 obsolete file)
54.78 KB,
image/png
|
Details | |
13.99 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0 Build ID: 20160726073904 Steps to reproduce: Created a contact with a large "notes" section. The "notes" have long lines and a few line breaks. Actual results: The space for the notes takes almost all the available horizontal width, leaving a few millimeters of horizontal width for the right-hand column (that holds phone numbers). Expected results: The width of the left-hand column of the contact information should take no more than the 100% minus the necessary width to display a whole phone number. Controlling the max-width of the main column should fix it easily.
Reporter | ||
Updated•8 years ago
|
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
Assignee | ||
Comment 1•8 years ago
|
||
The patch looks big but it's only indentation change for the new hbox with equalsize="always" to make the two columns have always the same width.
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8785630 -
Flags: review?(jorgk)
Comment 2•8 years ago
|
||
Can you please attach a patch without the indentation changes for review purposes only. Of course we land the indentation changes but I prefer to review five lines instead of 500 ;-)
Assignee | ||
Comment 3•8 years ago
|
||
Same patch without indentation for easier review.
Comment 4•8 years ago
|
||
Comment on attachment 8785630 [details] [diff] [review] Bug1296253.patch Thank you for the "review-only" patch. Yes, the contact details now display nicely in two equal columns. r=jorgk.
Attachment #8785630 -
Flags: review?(jorgk) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/60b332e98e13
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 51.0
Assignee | ||
Updated•8 years ago
|
Attachment #8785632 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•