1296253 - Horizontal space for notes in the address book makes phone numbers unreadable

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Jordi Aranés]

Attachment: contacts-bug.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160726073904

Steps to reproduce:

Created a contact with a large "notes" section. The "notes" have long lines and a few line breaks.


Actual results:

The space for the notes takes almost all the available horizontal width, leaving a few millimeters of horizontal width for the right-hand column (that holds phone numbers).


Expected results:

The width of the left-hand column of the contact information should take no more than the 100% minus the necessary width to display a whole phone number. Controlling the max-width of the main column should fix it easily.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug1296253.patch

The patch looks big but it's only indentation change for the new hbox with equalsize="always" to make the two columns have always the same width.

Comment 2

[Jorg K (CEST = GMT+2)]

Can you please attach a patch without the indentation changes for review purposes only. Of course we land the indentation changes but I prefer to review five lines instead of 500 ;-)

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug1296253-noIndent.patch

Same patch without indentation for easier review.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8785630 [details] [diff] [review]
Bug1296253.patch

Thank you for the "review-only" patch.
Yes, the contact details now display nicely in two equal columns.
r=jorgk.

Comment 5

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/60b332e98e13