129635 - Leaking PL_DHashTable and children

Status: VERIFIED FIXED

(Core :: Security: CAPS, defect, P2)

Description

[Alec Flett]

With spacetrace, I discovered that we're leaking a ton of hashtables out of
caps. basically we leak every DomainPolicy table, every ClassPolicy, and every
ClassPolicy's hashtable.

The solution was just to write a destructor for DomainPolicy.. patch forthcoming.

Comment 1

[Alec Flett]

Attachment: Add a destructor

here's the patch, can I get a review?

Comment 2

[Mitchell Stoltz (not reading bugmail)]

Comment on attachment 73153 [details] [diff] [review]
Add a destructor

Thanks, Alec! r=mstoltz. I usually bug jst or jband for sr's, but anyone will
do. Do you want me to drive this one in? I can take it.

Comment 3

[Mitchell Stoltz (not reading bugmail)]

Assigning to me.

Comment 4

[vidur (gone)]

Comment on attachment 73153 [details] [diff] [review]
Add a destructor

sr=vidur

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 73153 [details] [diff] [review]
Add a destructor

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 127913 has been marked as a duplicate of this bug. ***

Comment 7

[Mitchell Stoltz (not reading bugmail)]

Looks like Alec checked in the fix.

Comment 8

[bsharma]

Marking verified as per above developer comments.