1296600 - Review licenses for new external libraries: node-properties & sprintf.js (devtools)

Status: RESOLVED FIXED

(mozilla.org :: Licensing, task)

Description

[Julian Descottes [:jdescottes]]

(see Bug 1294220)

I want to use two external libraries in devtools (https://hg.mozilla.org/mozilla-central/file/tip/devtools). 

The libraries are :
- https://github.com/alexei/sprintf.js (license: https://github.com/alexei/sprintf.js/blob/master/LICENSE)
- https://github.com/gagle/node-properties (MIT license: https://github.com/gagle/node-properties/blob/master/LICENSE)

The files themselves would go in devtools/client/shared/vendor, which already contains other external libraries. 

Both libraries require modifications before we can use them.

What is the process to add those libraries here?

Comment 1

[Gervase Markham [:gerv]]

Both of these are fine. As devtools ships with Firefox (doesn't it? if it only ships with some versions, we may need to investigate ifdefs), you need to add the licenses to about:license, in alphabetical order - ask me to review the patch, please.

Gerv

Comment 2

[Julian Descottes [:jdescottes]]

(In reply to Gervase Markham [:gerv] from comment #1)
> Both of these are fine. As devtools ships with Firefox (doesn't it? if it
> only ships with some versions, we may need to investigate ifdefs), 
Yes it ships with Firefox, no need for ifdefs.

> you need
> to add the licenses to about:license, in alphabetical order - ask me to
> review the patch, please.

Will do, thanks for answering quickly!

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1296600 - add sprintf.js and node-properties licenses to about:license;

Review commit: https://reviewboard.mozilla.org/r/73132/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73132/

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 8783200 [details]
Bug 1296600 - add sprintf.js and node-properties licenses to about:license;

https://reviewboard.mozilla.org/r/73132/#review71078

r=gerv.

Comment 5

[Julian Descottes [:jdescottes]]

Thanks for the review!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a22d1d1dbb3e
add sprintf.js and node-properties licenses to about:license;r=gerv

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a22d1d1dbb3e