1296736 - Navigating to a non-remote URL from RDM breaks the tab

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:

1. Open some page like mozilla.org
2. Open RDM
3. Enter about:addons in the location bar

ER:

Add-ons manager loads, can navigate to other pages like normal.

AR:

Add-ons manager does actually load, but the tab is then "broken" after that, like the location bar doesn't work anymore, etc.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1296736 - Exit RDM when loading non-remote URLs.

Review commit: https://reviewboard.mozilla.org/r/86126/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86126/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Requires patch from bug 1310298, which might not have merged yet at the time of review.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e6f477b70ceb95c3ee8b3d837d435ff17225ea3

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8801345 [details]
Bug 1296736 - Exit RDM when loading non-remote URLs.

https://reviewboard.mozilla.org/r/86126/#review85130

Works great.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/904765470921
Exit RDM when loading non-remote URLs. r=ochameau

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/904765470921

Comment 6

[Mihai Boldan, Desktop QA [:mboldan]]

I managed to reproduce this issue on Firefox 52.0a1 (2016-10-10) and on Windows 10 x64.
The issue is no longer reproducible on Firefox 52.0a1 (2016-10-20).
Tests were performed under Windows 10 x64, Mac OS X 10.11.6 and under Ubuntu 14.04 x86.
I am marking this issue Verified Fixed.