Closed
Bug 1296800
Opened 8 years ago
Closed 8 years ago
Move non-proxy, non-doorhanger tests from test_prompt.html to its own file
Categories
(Toolkit :: Password Manager, defect, P3)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: MattN, Assigned: MattN)
References
Details
Attachments
(3 files)
In preparation for making the tests work in e10s (bug 1266618), move the simplest test_prompt.html tests to their own file.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8783164 [details] Bug 1296800 - Output test numbers in test_prompt.html. https://reviewboard.mozilla.org/r/73104/#review71804 In one sense the numbers are not useful, since the old testNum counter was removed. I think in other tests we converted it to an actual description of the test. OTOH, there's a lot of individual tests here, so it makes it easy to jump to the right spot. Would be nice if there was something that could just, I dunno, output a line number?
Attachment #8783164 -
Flags: review?(dolske) → review+
|
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8783165 [details] Bug 1296800 - Use separate setup and test tasks in test_prompt.html. https://reviewboard.mozilla.org/r/73106/#review71806
Attachment #8783165 -
Flags: review?(dolske) → review+
|
|
||
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8783166 [details] Bug 1296800 - test_prompt.html: Move promptAuth tests to their own test file. https://reviewboard.mozilla.org/r/73108/#review71816 ::: toolkit/components/passwordmgr/test/mochitest/test_prompt_promptAuth.html:1 (Diff revision 1) > +<!DOCTYPE HTML> Oops, please |hg copy| this file, looks like you didn't. (Or mozreview is confused, it's showing it as a new file with complete additions, not diffs from test_prompt).
Attachment #8783166 -
Flags: review?(dolske) → review+
|
Assignee | |
Comment 7•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8783164 [details] Bug 1296800 - Output test numbers in test_prompt.html. https://reviewboard.mozilla.org/r/73104/#review71804 Yeah, the remaining ones should be switched to add_task too which then outputs the test name. This was just an easy first step to help more easily know where the test fails.
|
|
Assignee | |
Comment 8•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8783166 [details] Bug 1296800 - test_prompt.html: Move promptAuth tests to their own test file. https://reviewboard.mozilla.org/r/73108/#review71816 > Oops, please |hg copy| this file, looks like you didn't. (Or mozreview is confused, it's showing it as a new file with complete additions, not diffs from test_prompt). Oops, I guess this got messed up in a rebase?
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 13•8 years ago
|
||
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/2c7cfad1bc2b Output test numbers in test_prompt.html. r=Dolske https://hg.mozilla.org/integration/autoland/rev/62ada473cc52 Use separate setup and test tasks in test_prompt.html. r=Dolske https://hg.mozilla.org/integration/autoland/rev/eb7d22f1a38d test_prompt.html: Move promptAuth tests to their own test file. r=Dolske
|
||
Comment 14•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2c7cfad1bc2b https://hg.mozilla.org/mozilla-central/rev/62ada473cc52 https://hg.mozilla.org/mozilla-central/rev/eb7d22f1a38d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•