1298193 - Fix test_prompt_promptAuth.html for e10s

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P3)

Description

[Matthew N. [:MattN]]

+++ This bug was initially created as a clone of Bug #1266618 +++

Follow the same basic scheme as bug 1266618.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1298193 - Part 1: Move promptAuth proxy tests to their own file.

More splitting of test_prompt.html to make these tests easier to maintain/digest.

Review commit: https://reviewboard.mozilla.org/r/74330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74330/

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 8785029 [details]
Bug 1298193 - Part 1: Move promptAuth proxy tests to their own file.

https://reviewboard.mozilla.org/r/74330/#review72192

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1298193 - Part 2: Switch test_prompt_promptAuth* to add_task.

Review commit: https://reviewboard.mozilla.org/r/74458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74458/

Comment 4

[Matthew N. [:MattN]]

Attachment: Bug 1298193 - Part 3: Don't manually remove logins at the end of test_prompt_promptAuth*.

Services.logins.removeAllLogins is already done in registerCleanupFunction

Review commit: https://reviewboard.mozilla.org/r/74460/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74460/

Comment 5

[Matthew N. [:MattN]]

Attachment: Bug 1298193 - Part 4: Remove storage observer from test_prompt_promptAuth_proxy.

Review commit: https://reviewboard.mozilla.org/r/74462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74462/

Comment 6

[Matthew N. [:MattN]]

Attachment: Bug 1298193 - Part 5: test_prompt_promptAuth_proxy doesn't need to clear auth sessions on its own.

Review commit: https://reviewboard.mozilla.org/r/74464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74464/

Comment 7

[Matthew N. [:MattN]]

Attachment: Bug 1298193 - Part 6: Remove storage observer from test_prompt_promptAuth.html and run setup in the chrome.

Review commit: https://reviewboard.mozilla.org/r/74466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74466/

Comment 8

[Matthew N. [:MattN]]

Attachment: Bug 1298193 - Part 7: Make test_prompt_promptAuth work with channels in the parent.

Review commit: https://reviewboard.mozilla.org/r/74468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74468/

Comment 9

[Matthew N. [:MattN]]

Attachment: Bug 1298193 - Part 8: Move pwmgr HTTP auth tests triggered by HTTP requests to their own file.

Review commit: https://reviewboard.mozilla.org/r/74470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74470/

Comment 10

[Matthew N. [:MattN]]

Comment on attachment 8785029 [details]
Bug 1298193 - Part 1: Move promptAuth proxy tests to their own file.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/74330/diff/1-2/

Comment 11

[Matthew N. [:MattN]]

I moved the tests that were loading authenticate.sjs iframes instead of using promptAuth out of the …prompt_promptAuth.html test file (it was a mistake they got moved there in the first place) and into a new test …prompt_http.html.

Comment 12

[Justin Dolske [:Dolske]]

Comment on attachment 8785160 [details]
Bug 1298193 - Part 2: Switch test_prompt_promptAuth* to add_task.

https://reviewboard.mozilla.org/r/74458/#review72470

Comment 13

[Justin Dolske [:Dolske]]

Comment on attachment 8785161 [details]
Bug 1298193 - Part 3: Don't manually remove logins at the end of test_prompt_promptAuth*.

https://reviewboard.mozilla.org/r/74460/#review72472

Comment 14

[Justin Dolske [:Dolske]]

Comment on attachment 8785162 [details]
Bug 1298193 - Part 4: Remove storage observer from test_prompt_promptAuth_proxy.

https://reviewboard.mozilla.org/r/74462/#review72474

Comment 15

[Justin Dolske [:Dolske]]

Comment on attachment 8785163 [details]
Bug 1298193 - Part 5: test_prompt_promptAuth_proxy doesn't need to clear auth sessions on its own.

https://reviewboard.mozilla.org/r/74464/#review72476

::: toolkit/components/passwordmgr/test/mochitest/test_prompt_promptAuth_proxy.html
(Diff revision 1)
> -
> -  // clear plain HTTP auth sessions before the test, to allow
> -  // running them more than once.
> -  var authMgr = Cc['@mozilla.org/network/http-auth-manager;1'].
> -                getService(Ci.nsIHttpAuthManager);
> -  authMgr.clearAll();

I'm not sure if if this also cleared proxy auth (I'd suspect it did). Might be worth checking to make sure any leftover proxy auth is still being cleared. Although given how rarely someone would need to debug this stuff, it probably doesn't matter either way.

Comment 16

[Justin Dolske [:Dolske]]

Comment on attachment 8785164 [details]
Bug 1298193 - Part 6: Remove storage observer from test_prompt_promptAuth.html and run setup in the chrome.

https://reviewboard.mozilla.org/r/74466/#review72478

Comment 17

[Justin Dolske [:Dolske]]

Comment on attachment 8785163 [details]
Bug 1298193 - Part 5: test_prompt_promptAuth_proxy doesn't need to clear auth sessions on its own.

https://reviewboard.mozilla.org/r/74464/#review72480

Comment 18

[Justin Dolske [:Dolske]]

Comment on attachment 8785165 [details]
Bug 1298193 - Part 7: Make test_prompt_promptAuth work with channels in the parent.

https://reviewboard.mozilla.org/r/74468/#review72482

Comment 19

[Justin Dolske [:Dolske]]

Comment on attachment 8785166 [details]
Bug 1298193 - Part 8: Move pwmgr HTTP auth tests triggered by HTTP requests to their own file.

https://reviewboard.mozilla.org/r/74470/#review72484

Comment 20

[Matthew N. [:MattN]]

Comment on attachment 8785163 [details]
Bug 1298193 - Part 5: test_prompt_promptAuth_proxy doesn't need to clear auth sessions on its own.

https://reviewboard.mozilla.org/r/74464/#review72476

> I'm not sure if if this also cleared proxy auth (I'd suspect it did). Might be worth checking to make sure any leftover proxy auth is still being cleared. Although given how rarely someone would need to debug this stuff, it probably doesn't matter either way.

I deleted this since pwmgr_common.js already does this exact same code in a registerCleanupFunction.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/e7f08c0a78b4
Part 1: Move promptAuth proxy tests to their own file. r=Dolske
https://hg.mozilla.org/integration/fx-team/rev/62eac8108589
Part 2: Switch test_prompt_promptAuth* to add_task. r=Dolske
https://hg.mozilla.org/integration/fx-team/rev/7e8890510e51
Part 3: Don't manually remove logins at the end of test_prompt_promptAuth*. r=Dolske
https://hg.mozilla.org/integration/fx-team/rev/42f5e31cf040
Part 4: Remove storage observer from test_prompt_promptAuth_proxy. r=Dolske
https://hg.mozilla.org/integration/fx-team/rev/92e257d137c5
Part 5: test_prompt_promptAuth_proxy doesn't need to clear auth sessions on its own. r=Dolske
https://hg.mozilla.org/integration/fx-team/rev/a3c4ad672325
Part 6: Remove storage observer from test_prompt_promptAuth.html and run setup in the chrome. r=Dolske
https://hg.mozilla.org/integration/fx-team/rev/74f737e158ed
Part 7: Make test_prompt_promptAuth work with channels in the parent. r=Dolske
https://hg.mozilla.org/integration/fx-team/rev/ad6a5176633b
Part 8: Move pwmgr HTTP auth tests triggered by HTTP requests to their own file. r=Dolske

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e7f08c0a78b4
https://hg.mozilla.org/mozilla-central/rev/62eac8108589
https://hg.mozilla.org/mozilla-central/rev/7e8890510e51
https://hg.mozilla.org/mozilla-central/rev/42f5e31cf040
https://hg.mozilla.org/mozilla-central/rev/92e257d137c5
https://hg.mozilla.org/mozilla-central/rev/a3c4ad672325
https://hg.mozilla.org/mozilla-central/rev/74f737e158ed
https://hg.mozilla.org/mozilla-central/rev/ad6a5176633b