[control center] Don't hardcode colors for the permission status and permission removal button

VERIFIED FIXED in Firefox 50

Status

()

P2
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug, {access, regression})

50 Branch
Firefox 51
access, regression
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox49 unaffected, firefox50+ verified, firefox51 verified)

Details

(Whiteboard: [fxprivacy])

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Created attachment 8783194 [details] [diff] [review]
patch

[Tracking Requested - why for this release]: regression for high-contrast mode support
Attachment #8783194 - Flags: review?(paolo.mozmail)

Comment 1

2 years ago
Comment on attachment 8783194 [details] [diff] [review]
patch

Looks good to me.
Attachment #8783194 - Flags: review?(paolo.mozmail) → review+

Comment 2

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4acecc737fa
[control center] Don't hardcode colors for the permission status and permission removal button. r=paolo

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d4acecc737fa
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51

Updated

2 years ago
Iteration: --- → 51.2 - Aug 29

Comment 4

2 years ago
Hi Dao, should we uplift this fix to Beta50?
tracking-firefox50: ? → +
Flags: needinfo?(dao+bmo)
Version: Trunk → 50 Branch
(Assignee)

Comment 5

2 years ago
Created attachment 8794089 [details] [diff] [review]
patch for beta

Approval Request Comment
[Feature/regressing bug #]: bug 1203292
[User impact if declined]: permission status hard to read in high contrast mode
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: straightforward CSS-only fix, very low risk
[String/UUID change made/needed]: none
Flags: needinfo?(dao+bmo)
Attachment #8794089 - Flags: approval-mozilla-beta?

Comment 6

2 years ago
Comment on attachment 8794089 [details] [diff] [review]
patch for beta

low-risk fix, has stabilized in 51 for a while, Beta50+
Attachment #8794089 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 7

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/8252fe02a827
status-firefox50: affected → fixed
Flags: qe-verify+
QA Contact: paul.silaghi
Verified fixed FX 50b2, 51.0a2 (2016-09-28) using high-contrast themes on Win 7.
Status: RESOLVED → VERIFIED
status-firefox50: fixed → verified
status-firefox51: fixed → verified
You need to log in before you can comment on or make changes to this bug.