Closed Bug 1296861 Opened 7 years ago Closed 7 years ago

[control center] Don't hardcode colors for the permission status and permission removal button

Categories

(Firefox :: Theme, defect, P2)

Product:
Firefox
Component:
Theme
Version:
50 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 51
Iteration:
51.2 - Aug 29
Tracking Flags:
Tracking Status
firefox49 --- unaffected
firefox50 + verified
firefox51 --- verified

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Keywords: access, regression, Whiteboard: [fxprivacy])

Attachments

(2 files)

patch
1.46 KB, patch
Paolo
: review+
Details | Diff | Splinter Review
patch for beta
1.50 KB, patch
ritu
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
[Tracking Requested - why for this release]: regression for high-contrast mode support
Attachment #8783194 - Flags: review?(paolo.mozmail)
Comment on attachment 8783194 [details] [diff] [review]
patch

Looks good to me.
Attachment #8783194 - Flags: review?(paolo.mozmail) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4acecc737fa
[control center] Don't hardcode colors for the permission status and permission removal button. r=paolo
https://hg.mozilla.org/mozilla-central/rev/d4acecc737fa
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Iteration: --- → 51.2 - Aug 29
Hi Dao, should we uplift this fix to Beta50?
tracking-firefox50: ? → +
Flags: needinfo?(dao+bmo)
Version: Trunk → 50 Branch
Attached patch patch for beta — — Splinter Review 
Approval Request Comment
[Feature/regressing bug #]: bug 1203292
[User impact if declined]: permission status hard to read in high contrast mode
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: straightforward CSS-only fix, very low risk
[String/UUID change made/needed]: none
Flags: needinfo?(dao+bmo)
Attachment #8794089 - Flags: approval-mozilla-beta?
Comment on attachment 8794089 [details] [diff] [review]
patch for beta

low-risk fix, has stabilized in 51 for a while, Beta50+
Attachment #8794089 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Contact: paul.silaghi
Verified fixed FX 50b2, 51.0a2 (2016-09-28) using high-contrast themes on Win 7.
Status: RESOLVED → VERIFIED
status-firefox50: fixed → verified
status-firefox51: fixed → verified
You need to log in before you can comment on or make changes to this bug.