Closed Bug 1296907 Opened 3 years ago Closed 3 years ago

Mac: window control buttons (caption / traffic light buttons) in private browsing windows are 1px too low

Categories

(Firefox :: Theme, defect)

51 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox48 --- unaffected
firefox49 --- fixed
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: mehmet.sahin, Assigned: Gijs)

References

Details

(Keywords: regression)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160820030224

Steps to reproduce:

Mac OS 10.11.6
Firefox Nightly 51.0a1 (2016-08-20)

1.) Open a Normal Window
2.) Open an Incognito Window
3.) Compare the height of the Window Control Buttons in both windows


Actual results:

The Window Control Buttons (traffic-lights) in Incognito Windows are 1px too low.


Expected results:

They must be 1px higher, to match the height of the buttons of the Normal Window.

A screenshot is attached.
Additional Information: It is a regression.
Component: Untriaged → Theme
Gijs, can you take a look? This may not be important to uplift to beta but we could take a patch in aurora.
Flags: needinfo?(gijskruitbosch+bugs)
Comment on attachment 8783709 [details]
Bug 1296907 - fix 1px offset of private browsing to 'normal' browsing window,

https://reviewboard.mozilla.org/r/73404/#review71216
Attachment #8783709 - Flags: review?(mstange) → review+
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e0bffa9456d6
fix 1px offset of private browsing to 'normal' browsing window, r=mstange
Comment on attachment 8783709 [details]
Bug 1296907 - fix 1px offset of private browsing to 'normal' browsing window,

Approval Request Comment
[Feature/regressing bug #]: bug 1275650
[User impact if declined]: private browsing buttons are slightly off compared to non-private-browsing buttons
[Describe test coverage new/current, TreeHerder]: nope, css-only
[Risks and why]: very low, css-only
[String/UUID change made/needed]: nope
Attachment #8783709 - Flags: approval-mozilla-beta?
Attachment #8783709 - Flags: approval-mozilla-aurora?
Summary: Mac: The Window Control Buttons (traffic-lights) in Incognito Windows are 1px too low → Mac: window control buttons (caption / traffic light buttons) in private browsing windows are 1px too low
https://hg.mozilla.org/mozilla-central/rev/e0bffa9456d6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Comment on attachment 8783709 [details]
Bug 1296907 - fix 1px offset of private browsing to 'normal' browsing window,

Small css fix, regression in 49, let's uplift for beta 7.
Attachment #8783709 - Flags: approval-mozilla-beta?
Attachment #8783709 - Flags: approval-mozilla-beta+
Attachment #8783709 - Flags: approval-mozilla-aurora?
Attachment #8783709 - Flags: approval-mozilla-aurora+
Hello Gijs Kruitbosch,

thanks for fixing it. I see the fix in latest Nightly, but it it seems that your fix only affects, when the titlebar is hidden. Can you please also fix this issue when the titlebar is active/visible .

Should I file a separate report for it?
(In reply to Mehmet from comment #11)
> Hello Gijs Kruitbosch,
> 
> thanks for fixing it. I see the fix in latest Nightly, but it it seems that
> your fix only affects, when the titlebar is hidden. Can you please also fix
> this issue when the titlebar is active/visible .
> 
> Should I file a separate report for it?

At this stage, probably. Is that also a regression?
Flags: needinfo?(mehmet.sahin)
(In reply to :Gijs Kruitbosch from comment #12) 
> At this stage, probably. Is that also a regression?

Before bug 1275650 was fixed, the buttons were also not aligned in both modes. They were in Private Window some pixels higher than in Normal Window (see FF Stable 48.0.1). Now, after bug 1275650 is fixed, the buttons in Private Window are 1px lower than in Normal Window as described in this bug when the titlebar is hidden.
FYI: Filed Bug 1297847.
Flags: needinfo?(mehmet.sahin)
You need to log in before you can comment on or make changes to this bug.