1296907 - Mac: window control buttons (caption / traffic light buttons) in private browsing windows are 1px too low

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Mehmet]

Attachment: Bug_Window_Control_Buttons.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160820030224

Steps to reproduce:

Mac OS 10.11.6
Firefox Nightly 51.0a1 (2016-08-20)

1.) Open a Normal Window
2.) Open an Incognito Window
3.) Compare the height of the Window Control Buttons in both windows


Actual results:

The Window Control Buttons (traffic-lights) in Incognito Windows are 1px too low.


Expected results:

They must be 1px higher, to match the height of the buttons of the Normal Window.

A screenshot is attached.

Comment 1

[Mehmet]

Additional Information: It is a regression.

Comment 2

[Tooru Fujisawa [:arai]]

Here's regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=432400265fed0d1b578877a181f45bc77ab2329e&tochange=b8adc67d8f4a5ddef0e021cff33b64d20508204f

seems like a regression from bug 1275650.

Comment 4

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Gijs, can you take a look? This may not be important to uplift to beta but we could take a patch in aurora.

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1296907 - fix 1px offset of private browsing to 'normal' browsing window,

Review commit: https://reviewboard.mozilla.org/r/73404/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73404/

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8783709 [details]
Bug 1296907 - fix 1px offset of private browsing to 'normal' browsing window,

https://reviewboard.mozilla.org/r/73404/#review71216

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0bffa9456d6
fix 1px offset of private browsing to 'normal' browsing window, r=mstange

Comment 8

[:Gijs (he/him)]

Comment on attachment 8783709 [details]
Bug 1296907 - fix 1px offset of private browsing to 'normal' browsing window,

Approval Request Comment
[Feature/regressing bug #]: bug 1275650
[User impact if declined]: private browsing buttons are slightly off compared to non-private-browsing buttons
[Describe test coverage new/current, TreeHerder]: nope, css-only
[Risks and why]: very low, css-only
[String/UUID change made/needed]: nope

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e0bffa9456d6

Comment 10

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 8783709 [details]
Bug 1296907 - fix 1px offset of private browsing to 'normal' browsing window,

Small css fix, regression in 49, let's uplift for beta 7.

Comment 11

[Mehmet]

Hello Gijs Kruitbosch,

thanks for fixing it. I see the fix in latest Nightly, but it it seems that your fix only affects, when the titlebar is hidden. Can you please also fix this issue when the titlebar is active/visible .

Should I file a separate report for it?

Comment 12

[:Gijs (he/him)]

(In reply to Mehmet from comment #11)
> Hello Gijs Kruitbosch,
> 
> thanks for fixing it. I see the fix in latest Nightly, but it it seems that
> your fix only affects, when the titlebar is hidden. Can you please also fix
> this issue when the titlebar is active/visible .
> 
> Should I file a separate report for it?

At this stage, probably. Is that also a regression?

Comment 13

[Mehmet]

(In reply to :Gijs Kruitbosch from comment #12) 
> At this stage, probably. Is that also a regression?

Before bug 1275650 was fixed, the buttons were also not aligned in both modes. They were in Private Window some pixels higher than in Normal Window (see FF Stable 48.0.1). Now, after bug 1275650 is fixed, the buttons in Private Window are 1px lower than in Normal Window as described in this bug when the titlebar is hidden.

Comment 14

[Mehmet]

FYI: Filed Bug 1297847.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/30b1e0880c0f

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a84b57a1e9f8