1296908 - since I updated firefox version 48, one of characters in keyboard does not working.

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect, P3)

Description

[mehdi.7070]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160817112116

Steps to reproduce:

I updated firefox to new version (48)


Actual results:

the character "," in persian keyboard (it is "و") does not working in firefox. it is working in other program in windows.


Expected results:

I expected use the character "و" in firefox

Comment 2

[Tooru Fujisawa [:arai]]

I cannot reproduce it by choosing Persian keyboard layout with non-Persian keyboard, and hitting "," key.
it might need Persian hardware keyboard...

anyway, this sounds similar to bug 1293505.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> it might need Persian hardware keyboard...

Hmm, "," key must share same USB HID code in any keyboard layout (i.e., the scan code value shouldn't depend on keyboard).

And I also cannot reproduce this bug on Win10.

Comment 4

[Tooru Fujisawa [:arai]]

Are you using some special software to modify keymap or layout, or using some special keyboard?

Comment 5

[mehdi.7070]

(In reply to Tooru Fujisawa [:arai] from comment #4)
> Are you using some special software to modify keymap or layout, or using
> some special keyboard?

Thank you for your attention.
No, I use standard keyboard layout of windows (Persian). Today, when I read your question, I Installed a new layout (Iranian Standard Persian Keyboard ISIRI 9147). with this layout, the character of "و" worked in firefox :))

Comment 6

[Tooru Fujisawa [:arai]]

Is there any difference in the place of something about "و" key between Perian and Iranian layouts?

Comment 7

[mehdi.7070]

(In reply to Tooru Fujisawa [:arai] from comment #6)
> Is there any difference in the place of something about "و" key between
> Perian and Iranian layouts?

Thank you for your attention.
No, the places are not differences.
"," in Persian layout in firefox = "" (not working)
"," in Persian layout in notepad = "و"
"," in Iranian layout in firefox = "و"
So the used key is the same.
Thanks.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Could you attach a log file which is generated with this build <https://archive.mozilla.org/pub/firefox/try-builds/[e-mail]-288940e742c718983ef86c38af3c1ef8a0f7b61f/try-win32/firefox-51.0a1.en-US.win32.zip>?

You need to specify environment variables as:

MOZ_LOG_FILE=~/fx.log (path to log file)
MOZ_LOG=NativeKeyWidgets:5,KeyboardLayoutWidgets:4,sync

Then, execute the firefox.exe in the zip (Note that, you need to close your Firefox if it's launched, and you might need to reboot your system to enable the environment variables in new Firefox instance).

Finally, press only "," key with Persian keyboard layout on Firefox and close Firefox. Then, attach the log file to this bug from "Add an attachment" link in this bug.

Note that the log includes every key stroke. So, please don't type your private things during logging the behavior.

Comment 9

[mehdi.7070]

Attachment: log : Persian style

Comment 10

[mehdi.7070]

Attachment: log : "Iranian Standard Persian" style

Comment 11

[mehdi.7070]

(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #8)
> Could you attach a log file which is generated with this build
> <https://archive.mozilla.org/pub/firefox/try-builds/[e-mail]-
> 288940e742c718983ef86c38af3c1ef8a0f7b61f/try-win32/firefox-51.0a1.en-US.
> win32.zip>?
> 
> You need to specify environment variables as:
> 
> MOZ_LOG_FILE=~/fx.log (path to log file)
> MOZ_LOG=NativeKeyWidgets:5,KeyboardLayoutWidgets:4,sync
> 
> Then, execute the firefox.exe in the zip (Note that, you need to close your
> Firefox if it's launched, and you might need to reboot your system to enable
> the environment variables in new Firefox instance).
> 
> Finally, press only "," key with Persian keyboard layout on Firefox and
> close Firefox. Then, attach the log file to this bug from "Add an
> attachment" link in this bug.
> 
> Note that the log includes every key stroke. So, please don't type your
> private things during logging the behavior.

Ok. Thank you. I created the log file with your help. I attaced 2 log files, one with Persian style and other with Iranian Style Persian.

Note: In your firefox, "و" was worked in Persian style!

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> Note: In your firefox, "و" was worked in Persian style!

Wow, really?? Could you try to test with today's (tomorrow's?) Nightly build? It includes some bug fixes which are also included in the test build.

Anyway, I'll investigate the log, thank you very much!

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Okay, I understand what occurs on your environment from the log (thank you, again!):

> NativeKey::NativeKey(), mKeyboardLayout=0x04290429, mFocusedWndBeforeDispatch=0x90916,
> mDOMKeyCode=0x143EAF18, mKeyNameIndex=USE_STRING, mCodeNameIndex=Comma, mModKeyState={ NumLock },
> mVirtualKeyCode=0x88, mOriginalVirtualKeyCode=0x88,
> mCommittedCharsAndModifiers={ 'و' (0x0648) [NumLock] }, mInputtingStringAndModifiers={},
> mShiftedString={}, mUnshiftedString={},
> mShiftedLatinChar=NULL (0x0000), mUnshiftedLatinChar=NULL (0x0000),
> mScanCode=0x0033, mIsExtended=false, mIsDeadKey=false,
> mIsPrintableKey=true, mIsOverridingKeyboardLayout=false

The m(Original)VirtualKeyCode value is important. 0x88 is unknown virtual key code value on Windows. Therefore, we hit same path of bug 1293505.

However, I still don't understand the reason why we cannot reproduce this bug. If we could, we'd include automated test for preventing same regression, though.

Comment 14

[mehdi.7070]

(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #12)
> > Note: In your firefox, "و" was worked in Persian style!
> 
> Wow, really?? Could you try to test with today's (tomorrow's?) Nightly
> build? It includes some bug fixes which are also included in the test build.
> 
> Anyway, I'll investigate the log, thank you very much!

Yes, I tested it agian, it's worked.
and yes, if you will send me the new version of Nightly build, I test it.

Thank you for your attention.

Comment 15

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to mehdi.7070 from comment #14)
> (In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #12)
> > > Note: In your firefox, "و" was worked in Persian style!
> > 
> > Wow, really?? Could you try to test with today's (tomorrow's?) Nightly
> > build? It includes some bug fixes which are also included in the test build.
> > 
> > Anyway, I'll investigate the log, thank you very much!
> 
> Yes, I tested it agian, it's worked.
> and yes, if you will send me the new version of Nightly build, I test it.

How about today's build?
https://nightly.mozilla.org/

Comment 16

[mehdi.7070]

(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #15)
> (In reply to mehdi.7070 from comment #14)
> > (In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #12)
> > > > Note: In your firefox, "و" was worked in Persian style!
> > > 
> > > Wow, really?? Could you try to test with today's (tomorrow's?) Nightly
> > > build? It includes some bug fixes which are also included in the test build.
> > > 
> > > Anyway, I'll investigate the log, thank you very much!
> > 
> > Yes, I tested it agian, it's worked.
> > and yes, if you will send me the new version of Nightly build, I test it.
> 
> How about today's build?
> https://nightly.mozilla.org/

Without any problem; It's worked correctly in both styles (Persian & Iranian Style Persian).
Thank you.

Comment 17

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you for verification!

Comment 18

[mehdi.7070]

(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #17)
> Thank you for verification!

Thank you again for your consideration

Comment 20

[mehdi.7070]

The bug is fixed in version 50.