1296918 - There is no need for that much padding, especially on the left in bookmarks toolbar

Status: VERIFIED WONTFIX

(Firefox :: Theme, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/message/reply/question/etc.)]

Attachment: proposition.png

There is no need for that much padding, especially on the left in bookmarks toolbar. The patch from bug #1294885 should be only applied to the padding on the right in bookmarks toolbar, because only there it caused unpolished look like items could appear pushed up against the edge of the window.
In other way, now, it looks inconsistent when you add some buttons to bookmarks toolbar and compare them to navigation toolbar etc. and also it changes mouse behavior to be more precise, as edges aren't functional as it was before.

But the better way will be applying padding only to the left on ">> - button" shown in attachment.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Can you explain more about the screenshot that you attached?

The padding was only added to the toolbar itself so it shouldn't affect the overflow button. Can you attach a screenshot of what your browser looks like without your proposal?

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/message/reply/question/etc.)]

Hmm, so let's hope you don't fall asleep during reading all of this. ;)

On my screenshot you can see my Firefox with Classic Theme Restorer extension to restore pre-Australis look. I have enabled Firefox menu and Bookmarks Toolbar. In Bookmarks Toolbar I placed Bookmarks button on the left to see bookmarks menu, as I reverted old look to have Star button in Location Bar. On the right side of Bookmarks Toolbar you can see from the right Downloads button, Flash Video Downloader button, uBlock Orgin button, Session Manager button and this ">>" button which shows more bookmarks. You can also see 1 bookmark folder named "mgr" and many bookmarks without names with only favicons present to save space.

The point of this bug is that bug #1294885 add useless padding to the both of edges of Bookmarks Toolbar. Making it inconsistent looking on buttons placing with other toolbars, especially Navigation Toolbar. Next annoyance is that edges aren't now functional like in other toolbars when you place buttons or other items there, so you have to be more precise with your mouse movement.

So my proposition is don't add any padding to the edges of the Bookmarks Toolbar,
instead add the padding to the left side of this ">>" button, which is shown when to bookmarks are placed to be seen in Bookmark Toolbar Items. This will fix these artifacts seen in bug #1294885 without any other disadvantages.

I hope I made myself clear, if not, I will try to answer any questions you have.

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/message/reply/question/etc.)]

Attachment: Customize Nightly.png

I'm attaching how my Customize Nightly looks like.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #2)
> The point of this bug is that bug #1294885 add useless padding to the both
> of edges of Bookmarks Toolbar. Making it inconsistent looking on buttons
> placing with other toolbars, especially Navigation Toolbar. 

The change from bug 1294885 in fact makes the bookmarks toolbar *more* consistent with the navigation toolbar. The left edge of the rounded back button now lines up with the left edge of the button of the first bookmark in the bookmarks toolbar.

However, your browser is customized very heavily to use the square back button and it appears that the three-line Firefox menu button on the right side is placed very close to the edge of your window.

Toolbar buttons, like the Downloads button, moved in to the bookmarks toolbar will now line up with the edge of the rounded back button. Yet with your customizations it does look out of place. 

Basically, there are so many customizations done to your browser that it would be hard for us to try to make any tweaks to the toolbars or menus without breaking how your styling looks or someone elses who has heavily styled their browser.

The vast majority of users who heavily style their browser are familiar with user stylesheets, Classic Theme Restorer, and other ways that they can adjust the UI to their liking. Undoing this padding would be better left to the job of CTR or the like.

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/message/reply/question/etc.)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> (In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #2)
> > The point of this bug is that bug #1294885 add useless padding to the both
> > of edges of Bookmarks Toolbar. Making it inconsistent looking on buttons
> > placing with other toolbars, especially Navigation Toolbar. 
> 
> The change from bug 1294885 in fact makes the bookmarks toolbar *more*
> consistent with the navigation toolbar. The left edge of the rounded back
> button now lines up with the left edge of the button of the first bookmark
> in the bookmarks toolbar.
> 
> However, your browser is customized very heavily to use the square back
> button and it appears that the three-line Firefox menu button on the right
> side is placed very close to the edge of your window.
> 
> Toolbar buttons, like the Downloads button, moved in to the bookmarks
> toolbar will now line up with the edge of the rounded back button. Yet with
> your customizations it does look out of place. 
> 
> Basically, there are so many customizations done to your browser that it
> would be hard for us to try to make any tweaks to the toolbars or menus
> without breaking how your styling looks or someone elses who has heavily
> styled their browser.

I'm very sorry for the confusion I caused. Looks like my bug hunter skills gotten rusty this time, as I didn't checked the clean new fresh profile without any addons.
You are completely right, the default Firefox look with patch from bug #1294885 makes it looks more consistent.