1296938 - https://github.com/blog/2231-building-your-first-atom-plugin causes 3GB ram use from animated GIFs

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[Mayank Bansal]

Attachment: memory-report.json.gz

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160821030226

Steps to reproduce:

1. Create fresh profile
2. Go to https://github.com/blog/2231-building-your-first-atom-plugin
3. Let the page load. For good measure, scroll up and down the page with the scroll bar multiple times


Actual results:

memory use goes to 2.8GB !


Expected results:

probably not this.

Comment 1

[Mayank Bansal]

Attachment: aboutsupport.txt

Comment 2

[Mayank Bansal]

tentative ni?

Comment 3

[Jim Jeffery not reading bug-mail 1/2/11]

I didn't let get over 1gig, but it quickly got there.  I suspect those 'gifs' or whatever they are repeating over & over is likely cause.

Confirming, setting to NEW

Test on today's Nightly, win10 x64 m-c win32 builds.

Comment 4

[Fanolian]

At least Nightly is trading memory usage for (scrolling) performance, and discarding memory properly after closing the tab.

In each videos, for every browsers I scroll the page all the way up and down with my mouse with an infinite scrolling wheel. (Granted, no one does this in normal browsing; just a comparison.)

https://www.youtube.com/watch?v=oIa413TD7-U
In Nightly, scrolling is smooth and content is invalidated(?) the least. High CPU usage is affecting other tabs' performance though.

https://www.youtube.com/watch?v=6wVftEqvzlg
Edge scrolls smoothly too but content are all invalidated during scrolling.

https://www.youtube.com/watch?v=UrIXCIjtdgM
Chrome's scrolling is very sluggish. Memory usage may spike to about 1.7GB but drops quickly.

Comment 5

[Jim Jeffery not reading bug-mail 1/2/11]

Just ran a quick test in IE11 in win10 x64 and the memory was sky-rocketing before page even finished loading.

This looks to me like a poorly coded page or something.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

The memory usage here is due to high resolution animated gifs. We plan on fixing this, though I do not know the bugs where the work is tracked.

Comment 7

[Mayank Bansal]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #6)
> The memory usage here is due to high resolution animated gifs. We plan on
> fixing this, though I do not know the bugs where the work is tracked.


Would that be bug 1289954 ?

Comment 8

[Timothy Nikkel (:tnikkel)]

This is actually a regression from bug 1293472 because of this hunk https://hg.mozilla.org/mozilla-central/rev/02f9e27b988d#l1.105 where the new code lies about the size of all animated images as if they had only 3 frames. This allows more of the image frames to be decoded and go above the limit on the size of the surface cache (whereas before that change we held more closely to the limit).

Comment 9

[musa11971]

Experiencing the same bug on the following github page:

https://github.com/Southclaws/sampctl

I "fixed" it by blocking the source of the images via a custom uBlock origin filter.

Comment 10

[Timothy Nikkel (:tnikkel)]

This should be fixed now by Andrew's frame discarding work. If anyone still sees this problem or similar please re-open or file a new bug.