Closed Bug 1296945 Opened 3 years ago Closed 3 years ago

Identity popup's security view footer should use --panel-separator-color instead of #ccc for the border

Categories

(Firefox :: Theme, defect, P4)

defect

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: dao, Assigned: torroid, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1293967 +++

https://hg.mozilla.org/mozilla-central/annotate/f97a056ae6235de7855fd8aaa04fb1c8d183bd06/browser/themes/shared/controlcenter/panel.inc.css#l284

#ccc doesn't work well with dark and high-contrast themes. We should use var(--panel-separator-color) instead.
Mentor: dao+bmo
Comment on attachment 8784366 [details] [diff] [review]
Identity popup's security view footer border changed from #ccc to var( --panel-separator-color)

Looks good. Thanks!
Attachment #8784366 - Flags: review?(dao+bmo) → review+
Assignee: nobody → glenn28f
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/268f50cd097c
Identity popup's security view footer should use --panel-separator-color instead of #ccc for the border. r=dao
https://hg.mozilla.org/mozilla-central/rev/268f50cd097c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Blocks: 1202280
You need to log in before you can comment on or make changes to this bug.