1296948 - Index IPDL files

Status: RESOLVED FIXED

(Webtools :: Searchfox, defect)

Comment 1

[Andrew McCreight [:mccr8]]

This is fixed now, right?

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I think it somehow got busted! It's not working for me now.

Comment 3

[Andrew McCreight [:mccr8]]

I see the files here, and there's syntax highlighting.
  https://searchfox.org/mozilla-central/source/dom/ipc/PContent.ipdl
Is it supposed to link to the definitions of things? It has been a while since I've done anything with ipdl so I don't remember.

Comment 4

[Andrew McCreight [:mccr8]]

I'll take a look over ipdl-analyze.rs and figure out what it is supposed to be doing, and whether it is working or not.

Comment 5

[Andrew McCreight [:mccr8]]

The first problem I've come across is that bug 1389314 added a new priority, so we fail to parse some files and abort. It seems easy to fix, but now I'm hitting problems where a library I use won't compile any more. I guess I have to bump the versions I use? Hopefully that won't break anything else.

Comment 6

[Andrew McCreight [:mccr8]]

Oh, I see, it looks like the searchfox version of the IPDL parser contains some changes that haven't been upstreamed. I'll do that.

Comment 7

[Andrew McCreight [:mccr8]]

Bug 1351148 added a new priority, so some files don't parse. I also need to upstream some fixes build made to the Cargo file so it will build.

Comment 8

[Andrew McCreight [:mccr8]]

I fixed the Rust IPDL parser so it handles the new priority, and locally confirmed that this is sufficient to make IPDL files have links again.

I submitted a pull request to Bill's mirror of the Rust IPDL parser with the fix:
  https://github.com/bill-mccloskey/ipdl_parser/pull/1

Once that is merged, I'll submit a pull request to update the version in the SearchFox subrepo.

Comment 9

[Andrew McCreight [:mccr8]]

https://github.com/bill-mccloskey/mozsearch/pull/39

I'm going to assign this to Bill, because he actually did the work on SearchFox integration. I merely fixed a parser bug here. ;)