1418508 - Disable analyzing IPDL on comm-central

Status: NEW

(Webtools :: Searchfox, defect)

Description

[Andrew McCreight [:mccr8]]

Analysis fails for PGMPService.ipdl, while run on AWS:

Parsing file /index/comm-central/comm-central/mozilla/widget/headless/HeadlessWidgetTypes.ipdlh
Analyzing "/index/comm-central/comm-central/mozilla/netwerk/ipc/NeckoChannelParams.ipdlh"
Analyzing "/index/comm-central/comm-central/mozilla/dom/media/gmp/PGMPService.ipdl"
thread 'main' panicked at 'No analysis target found for _ZN7mozilla3gmp16PGMPServiceChild13SendLaunchGMPE', src/bin/ipdl-analyze.rs:66:4

I worked around this by making the error non-fatal, but it would be good fix it so we get more links.

I can't reproduce the problem locally. I don't know if my VM somehow has a different version of the compiler or what. I did notice the the files are being analyzed in a different order. I don't know if that could be a factor.

Comment 1

[Andrew McCreight [:mccr8]]

I could make the order more deterministic by changing |tuids| to be a BTreeMap instead of a HashMap (IIRC it is set up so the tuid keys are deterministic, and they look like they are at least locally), but looking at the code now I can't see how that might make a difference. I may have to try debugging this on an AWS instance.

Comment 2

[Andrew McCreight [:mccr8]]

Oh, I just noticed that this is happening while indexing comm-central, not mozilla-central. This file looks fine in m-c on searchfox, but it isn't being linkified on c-c. Maybe we don't build this file on c-c, so there's some missing output, but we're still analyzing all IPDL files?

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I turned off C++ indexing on c-c a while back. IPDL files still get analyzed, though. We should probably turn that off.