Closed
Bug 1296993
Opened 7 years ago
Closed 7 years ago
DeCOMtaminate nsIWidget some more
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
(Blocks 1 open bug)
Details
(Whiteboard: tpi:+)
Attachments
(8 files)
|
17.74 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
|
11.10 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
|
22.51 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
|
14.34 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
|
17.16 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
|
6.31 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
|
18.73 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
|
8.96 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
Continuing the work started in bug 1293596.
|
Assignee | |
Comment 1•7 years ago
|
||
This patch does the following. - Removes the return value, because none of the call sites check it. - Puts an empty implementation into nsBaseWidget. - Removes the empty implementations from several nsIWidget instances, because they can use the nsBaseWidget one.
Attachment #8784673 -
Flags: review?(mstange)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•7 years ago
|
||
This patch does the following. - Removes the return value, because none of the call sites check it. - Removes the empty implementations from several nsIWidget instances, because they can use the nsBaseWidget one.
Attachment #8784675 -
Flags: review?(mstange)
|
|
Assignee | |
Comment 3•7 years ago
|
||
This patch does the following. - Removes the return value, because none of the call sites check it. - Puts an empty implementation into nsBaseWidget. - Removes the empty implementations from several nsIWidget instances, because they can use the nsBaseWidget one.
Attachment #8784676 -
Flags: review?(mstange)
|
|
Assignee | |
Comment 4•7 years ago
|
||
This patch does the following. - Removes the return value, because none of the call sites check it. - Removes the empty implementations from several nsIWidget instances, because they can use the nsBaseWidget one.
Attachment #8784677 -
Flags: review?(mstange)
|
|
Assignee | |
Comment 5•7 years ago
|
||
This patch removes the return value, because none of the call sites check it.
Attachment #8784678 -
Flags: review?(mstange)
|
|
Assignee | |
Comment 6•7 years ago
|
||
This patch removes the return value, because none of the call sites check it.
Attachment #8784679 -
Flags: review?(mstange)
|
|
Assignee | |
Comment 7•7 years ago
|
||
This patch does the following. - Removes the return value, because none of the call sites check it. - Puts an empty implementation into nsBaseWidget. - Removes the empty implementations from several nsIWidget instances, because they can use the nsBaseWidget one.
Attachment #8784680 -
Flags: review?(mstange)
|
|
Assignee | |
Comment 8•7 years ago
|
||
This patch does the following. - Removes the return value, because none of the call sites check it. - Removes the empty implementations from several nsIWidget instances, because they can use the nsBaseWidget one.
Attachment #8784681 -
Flags: review?(mstange)
|
||
Updated•7 years ago
|
Attachment #8784673 -
Flags: review?(mstange) → review+
|
|
||
Comment 9•7 years ago
|
||
Comment on attachment 8784675 [details] [diff] [review] (part 2) - Streamline nsIWidget::Set{,Fake}Modal Review of attachment 8784675 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/cocoa/nsCocoaWindow.mm @@ +646,2 @@ > { > + // XXX: does this function need an Objective C try block around it? Yes it does, good catch.
Attachment #8784675 -
Flags: review?(mstange) → review+
|
|
||
Comment 10•7 years ago
|
||
Comment on attachment 8784676 [details] [diff] [review] (part 3) - Streamline nsIWidget::ConstrainPosition Review of attachment 8784676 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/cocoa/nsCocoaWindow.mm @@ +1115,2 @@ > { > + // XXX: does this function need an Objective C try block around it? yup
Attachment #8784676 -
Flags: review?(mstange) → review+
|
|
||
Updated•7 years ago
|
Attachment #8784677 -
Flags: review?(mstange) → review+
|
|
||
Updated•7 years ago
|
Attachment #8784678 -
Flags: review?(mstange) → review+
|
|
||
Updated•7 years ago
|
Attachment #8784679 -
Flags: review?(mstange) → review+
|
|
||
Updated•7 years ago
|
Attachment #8784680 -
Flags: review?(mstange) → review+
|
|
||
Updated•7 years ago
|
Attachment #8784681 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 11•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecf67f1108ea1f65df2810b5aceaedd6511d9512 Bug 1296993 (part 1) - Streamline nsIWidget::ReparentNativeWidget. r=mstange. https://hg.mozilla.org/integration/mozilla-inbound/rev/6d772aecca501b8b1c083bf242c4a31c0cf3f768 Bug 1296993 (part 2) - Streamline nsIWidget::Set{,Fake}Modal. r=mstange. https://hg.mozilla.org/integration/mozilla-inbound/rev/b349f99120ab97864c79a5b0a68ff1d490f5775e Bug 1296993 (part 3) - Streamline nsIWidget::ConstrainPosition. r=mstange. https://hg.mozilla.org/integration/mozilla-inbound/rev/83bc87a0beaf6ce2faa0c5091921ff4ec158728a Bug 1296993 (part 4) - Streamline nsIWidget::PlaceBehind. r=mstange. https://hg.mozilla.org/integration/mozilla-inbound/rev/b225b2fcd94650b7da2adb688093a96ec8db8e8a Bug 1296993 (part 5) - Streamline nsIWidget::SetWindow{ShadowStyle,TitlebarColor,Class}. r=mstange. https://hg.mozilla.org/integration/mozilla-inbound/rev/26b025f9f147d52435a9071c57559c93e48aa7b1 Bug 1296993 (part 6) - Streamline nsIWidget::SetPluginFocused. r=mstange. https://hg.mozilla.org/integration/mozilla-inbound/rev/a2aece29443753914c3e6da9ad98c44045bda0ca Bug 1296993 (part 7) - Streamline nsIWidget::CaptureRollupEvents. r=mstange. https://hg.mozilla.org/integration/mozilla-inbound/rev/ac421daef9ff2cbbcd95d9ec2ddae2435a178063 Bug 1296993 (part 8) - Streamline nsIWidget::CaptureMouse. r=mstange.
|
||
Comment 12•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ecf67f1108ea https://hg.mozilla.org/mozilla-central/rev/6d772aecca50 https://hg.mozilla.org/mozilla-central/rev/b349f99120ab https://hg.mozilla.org/mozilla-central/rev/83bc87a0beaf https://hg.mozilla.org/mozilla-central/rev/b225b2fcd946 https://hg.mozilla.org/mozilla-central/rev/26b025f9f147 https://hg.mozilla.org/mozilla-central/rev/a2aece294437 https://hg.mozilla.org/mozilla-central/rev/ac421daef9ff
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•