Closed Bug 1296993 Opened 4 years ago Closed 4 years ago

DeCOMtaminate nsIWidget some more

Categories

(Core :: Widget, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: njn, Assigned: njn)

References

(Blocks 1 open bug)

Details

(Whiteboard: tpi:+)

Attachments

(8 files)

Continuing the work started in bug 1293596.
This patch does the following.

- Removes the return value, because none of the call sites check it.

- Puts an empty implementation into nsBaseWidget.

- Removes the empty implementations from several nsIWidget instances, because
  they can use the nsBaseWidget one.
Attachment #8784673 - Flags: review?(mstange)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
This patch does the following.

- Removes the return value, because none of the call sites check it.

- Removes the empty implementations from several nsIWidget instances, because
  they can use the nsBaseWidget one.
Attachment #8784675 - Flags: review?(mstange)
This patch does the following.

- Removes the return value, because none of the call sites check it.

- Puts an empty implementation into nsBaseWidget.

- Removes the empty implementations from several nsIWidget instances, because
  they can use the nsBaseWidget one.
Attachment #8784676 - Flags: review?(mstange)
This patch does the following.

- Removes the return value, because none of the call sites check it.

- Removes the empty implementations from several nsIWidget instances, because
  they can use the nsBaseWidget one.
Attachment #8784677 - Flags: review?(mstange)
This patch removes the return value, because none of the call sites check it.
Attachment #8784678 - Flags: review?(mstange)
This patch removes the return value, because none of the call sites check it.
Attachment #8784679 - Flags: review?(mstange)
This patch does the following.

- Removes the return value, because none of the call sites check it.

- Puts an empty implementation into nsBaseWidget.

- Removes the empty implementations from several nsIWidget instances, because
  they can use the nsBaseWidget one.
Attachment #8784680 - Flags: review?(mstange)
This patch does the following.

- Removes the return value, because none of the call sites check it.

- Removes the empty implementations from several nsIWidget instances, because
  they can use the nsBaseWidget one.
Attachment #8784681 - Flags: review?(mstange)
Attachment #8784673 - Flags: review?(mstange) → review+
Comment on attachment 8784675 [details] [diff] [review]
(part 2) - Streamline nsIWidget::Set{,Fake}Modal

Review of attachment 8784675 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsCocoaWindow.mm
@@ +646,2 @@
>  {
> +  // XXX: does this function need an Objective C try block around it?

Yes it does, good catch.
Attachment #8784675 - Flags: review?(mstange) → review+
Comment on attachment 8784676 [details] [diff] [review]
(part 3) - Streamline nsIWidget::ConstrainPosition

Review of attachment 8784676 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsCocoaWindow.mm
@@ +1115,2 @@
>  {
> +  // XXX: does this function need an Objective C try block around it?

yup
Attachment #8784676 - Flags: review?(mstange) → review+
Attachment #8784677 - Flags: review?(mstange) → review+
Attachment #8784678 - Flags: review?(mstange) → review+
Attachment #8784679 - Flags: review?(mstange) → review+
Attachment #8784680 - Flags: review?(mstange) → review+
Attachment #8784681 - Flags: review?(mstange) → review+
You need to log in before you can comment on or make changes to this bug.