Closed Bug 1296993 Opened 8 years ago Closed 8 years ago

DeCOMtaminate nsIWidget some more

Categories

(Core :: Widget, defect)

Product:
Core
Component:
Widget
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

(Blocks 1 open bug)

Details

(Whiteboard: tpi:+)

Attachments

(8 files)

(part 1) - Streamline nsIWidget::ReparentNativeWidget
17.74 KB, patch
mstange
: review+
Details | Diff | Splinter Review
(part 2) - Streamline nsIWidget::Set{,Fake}Modal
11.10 KB, patch
mstange
: review+
Details | Diff | Splinter Review
(part 3) - Streamline nsIWidget::ConstrainPosition
22.51 KB, patch
mstange
: review+
Details | Diff | Splinter Review
(part 4) - Streamline nsIWidget::PlaceBehind
14.34 KB, patch
mstange
: review+
Details | Diff | Splinter Review
(part 5) - Streamline nsIWidget::SetWindow{ShadowStyle,TitlebarColor,Class}
17.16 KB, patch
mstange
: review+
Details | Diff | Splinter Review
(part 6) - Streamline nsIWidget::SetPluginFocused
6.31 KB, patch
mstange
: review+
Details | Diff | Splinter Review
(part 7) - Streamline nsIWidget::CaptureRollupEvents
18.73 KB, patch
mstange
: review+
Details | Diff | Splinter Review
(part 8) - Streamline nsIWidget::CaptureMouse
8.96 KB, patch
mstange
: review+
Details | Diff | Splinter Review
Continuing the work started in bug 1293596.
This patch does the following. - Removes the return value, because none of the call sites check it. - Puts an empty implementation into nsBaseWidget. - Removes the empty implementations from several nsIWidget instances, because they can use the nsBaseWidget one.
Attachment #8784673 - Flags: review?(mstange)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
This patch does the following. - Removes the return value, because none of the call sites check it. - Removes the empty implementations from several nsIWidget instances, because they can use the nsBaseWidget one.
Attachment #8784675 - Flags: review?(mstange)
This patch does the following. - Removes the return value, because none of the call sites check it. - Puts an empty implementation into nsBaseWidget. - Removes the empty implementations from several nsIWidget instances, because they can use the nsBaseWidget one.
Attachment #8784676 - Flags: review?(mstange)
This patch does the following. - Removes the return value, because none of the call sites check it. - Removes the empty implementations from several nsIWidget instances, because they can use the nsBaseWidget one.
Attachment #8784677 - Flags: review?(mstange)
This patch removes the return value, because none of the call sites check it.
Attachment #8784678 - Flags: review?(mstange)
This patch removes the return value, because none of the call sites check it.
Attachment #8784679 - Flags: review?(mstange)
This patch does the following. - Removes the return value, because none of the call sites check it. - Puts an empty implementation into nsBaseWidget. - Removes the empty implementations from several nsIWidget instances, because they can use the nsBaseWidget one.
Attachment #8784680 - Flags: review?(mstange)
This patch does the following. - Removes the return value, because none of the call sites check it. - Removes the empty implementations from several nsIWidget instances, because they can use the nsBaseWidget one.
Attachment #8784681 - Flags: review?(mstange)
Attachment #8784673 - Flags: review?(mstange) → review+
Comment on attachment 8784675 [details] [diff] [review] (part 2) - Streamline nsIWidget::Set{,Fake}Modal Review of attachment 8784675 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/cocoa/nsCocoaWindow.mm @@ +646,2 @@ > { > + // XXX: does this function need an Objective C try block around it? Yes it does, good catch.
Attachment #8784675 - Flags: review?(mstange) → review+
Comment on attachment 8784676 [details] [diff] [review] (part 3) - Streamline nsIWidget::ConstrainPosition Review of attachment 8784676 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/cocoa/nsCocoaWindow.mm @@ +1115,2 @@ > { > + // XXX: does this function need an Objective C try block around it? yup
Attachment #8784676 - Flags: review?(mstange) → review+
Attachment #8784677 - Flags: review?(mstange) → review+
Attachment #8784678 - Flags: review?(mstange) → review+
Attachment #8784679 - Flags: review?(mstange) → review+
Attachment #8784680 - Flags: review?(mstange) → review+
Attachment #8784681 - Flags: review?(mstange) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: