1297105 - Invalid array access in mozilla::gfx::impl::VRDisplayOculus::GetNextRenderTarget()

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Andrew McCreight [:mccr8]]

This bug was filed from the Socorro interface and is 
report bp-a133d36c-1e68-440e-aab6-670a82160821.
=============================================================

Here's a second report:
  bp-8d3e723f-a8fe-4431-8137-f54732160818

Comment 1

[Andrew McCreight [:mccr8]]

Bug 1159244 added a release assert to array bounds checking. Can you take a look at this, Kip? Thanks.

Comment 2

[:kip (Kearwood Gilbert)]

I'll investigate, thanks!

Comment 3

[Andrew McCreight [:mccr8]]

Under the metadata tab, these crashes both have: "ElementAt(aIndex = 0, aLength = 0)". So the code is attempting to access index 0 of an empty array.

Comment 4

[:kip (Kearwood Gilbert)]

This may be happening if the DX11 objects are failing to be created for blitting the Oculus headset texture, resulting in this array not being populated.  Patch is incoming...

Comment 5

[:kip (Kearwood Gilbert)]

Attachment: Bug 1297105 - Prevent crash when DX11 resources fail to be allocated for Oculus VR HMD presentation

Review commit: https://reviewboard.mozilla.org/r/75440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75440/

Comment 6

[:kip (Kearwood Gilbert)]

Comment on attachment 8786519 [details]
Bug 1297105 - Prevent crash when DX11 resources fail to be allocated for Oculus VR HMD presentation

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/75440/diff/1-2/

Comment 7

[Andrew McCreight [:mccr8]]

Comment on attachment 8786519 [details]
Bug 1297105 - Prevent crash when DX11 resources fail to be allocated for Oculus VR HMD presentation

https://reviewboard.mozilla.org/r/75440/#review74424

Looks reasonable to me.

::: gfx/vr/gfxVROculus.cpp:768
(Diff revision 2)
> +     * XXX - We should resolve fail the promise returned by
> +     *       VRDisplay.requestPresent() when the DX11 resources fail allocation
> +     *       in VRDisplayOculus::StartPresentation().
> +     *       Bailing out here prevents the crash but content should be aware
> +     *       that frames are not being presented.
> +     *       See Bug 1299309

nit: This should have a period at the end.

Comment 8

[:kip (Kearwood Gilbert)]

Comment on attachment 8786519 [details]
Bug 1297105 - Prevent crash when DX11 resources fail to be allocated for Oculus VR HMD presentation

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/75440/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3c6df384b47
Prevent crash when DX11 resources fail to be allocated for Oculus VR HMD presentation r=mccr8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a3c6df384b47