1297170 - Several text-links in about:preferences improperly responds to secondary mouse button click.

Status: RESOLVED DUPLICATE of bug 1120967

(Firefox :: Settings UI, defect)

Description

[Tooru Fujisawa [:arai]]

Steps to Reproduce:
  1. open about:preferences
  2. open Privacy pane
  3. secondary mouse button click "manage your Do Not Track settings" link

Actual result:
  "Do Not Track" dialog is shown.

Expected result:
  Either nothing happens or context menu is shown.

Same thing happens in the following places:
  Privacy pane - "manage your Do Not Track settings" link
  Privacy pane - "clear your recent history" link
  Privacy pane - "remove individual cookies" link
  Privacy pane - "clear all current history" link
  Sync pane - "Terms of Service" link
  Sync pane - "Privacy Notice" link

Comment 1

[Tooru Fujisawa [:arai]]

looks like there are a lot more cases in about:preferences that doesn't check event.button in onclick :/

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Check event.button in click event handler in about:preferences.

In all cases, it should ignore click with not-primary button.

[applications.js]
  gApplicationsPane.sort
    called from type/action column headers

[content.js]
  gContentPane.openTranslationProviderAttribution
    called from translation attribution icon on localized build

[main.js]
  gMainPane.onGetStarted
    called from "Start using Sync..." text-link on Aurora

[privacy.js]
  historyRememberClear
    called from "clear your recent history" text-link
  historyRememberCookies
    called from "remove individual cookies" text-link
  historyDontRememberClear
    called from "clear all current history" text-link
  doNotTrackSettings
    called from "manage your Do Not Track settings" text-link

[sync.js]
  noAccountSetup
    called from "Set Up Firefox Sync" text-link
  noAccountPair
  syncAddDeviceLabel
    called from "Pair a Device" text-links
  unlinkDevice
    called from "Unlink This Device" text-link
  loginErrorUpdatePass
    called from "Update" text-link
  loginErrorResetPass
    called from "Reset" text-link
  loginErrorStartOver
    called from "Unlink This Device" text-link
  gSyncPane.openPrivacyPolicy
    called from "Privacy Policy" text-links
  gSyncPane.openToS
    called from "Terms of Service" text-links

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Hi Tooru, thanks for the patch. This work is actually already being worked on in https://bugzilla.mozilla.org/show_bug.cgi?id=1120967 where the goal there is treat those non-primary clicks as they way that normal right-clicking or middle-clicking on a link would do.

Comment 4

[Tooru Fujisawa [:arai]]

I see, thanks :)