Closed Bug 1301813 Opened 3 years ago Closed 3 years ago

"Change preferences for search engine suggestions..." doesn't respond to secondary mouse clicking in about:preferences, Privacy pane

Categories

(Firefox :: Preferences, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 51
Tracking Status
firefox51 --- verified

People

(Reporter: arai, Assigned: Fischer)

References

Details

Attachments

(1 file)

(In reply to Fischer [:Fischer] from bug 1120967 comment #6)
> * For middle-mouse clicking a website link will open that link in a new tab
> 
> * For middle/right-mouse clicking
>      'Privacy - Change preferences for search engine suggestions...', 
>      'Privacy - clear your recent history',
>      'Privacy - show 'Clear Recent History',
>      'Privacy - Manage your Do Not Track settings"
> will launch the corresponding function.

"Change preferences for search engine suggestions..." in Privacy pane doesn't follow it.

https://dxr.mozilla.org/mozilla-central/rev/176aff980979bf588baed78c2824571a6a7f2b96/browser/components/preferences/in-content/privacy.xul#280
>   <label class="text-link" onclick="if (event.button == 0) gotoPref('search')">
>     &suggestionSettings.label;
>   </label>

It checks `event.button == 0`, so it responds only for primary mouse click.

while I prefer checking `event.button` for all those links like this (see bug 1297170) tho, at least those links should behave consistently.
See Also: → 1297170
(In reply to Tooru Fujisawa [:arai] from comment #0)
> (In reply to Fischer [:Fischer] from bug 1120967 comment #6)
> > * For middle-mouse clicking a website link will open that link in a new tab
> > 
> > * For middle/right-mouse clicking
> >      'Privacy - Change preferences for search engine suggestions...', 
> >      'Privacy - clear your recent history',
> >      'Privacy - show 'Clear Recent History',
> >      'Privacy - Manage your Do Not Track settings"
> > will launch the corresponding function.
> 
> "Change preferences for search engine suggestions..." in Privacy pane
> doesn't follow it.
> 
> https://dxr.mozilla.org/mozilla-central/rev/
> 176aff980979bf588baed78c2824571a6a7f2b96/browser/components/preferences/in-
> content/privacy.xul#280
> >   <label class="text-link" onclick="if (event.button == 0) gotoPref('search')">
> >     &suggestionSettings.label;
> >   </label>
> 
Yes, `event.button == 0` is unnecessary. The bug 1120967 patch should have removed this checking.
However, it got missed during patch updates. I will submit a patch to fix.
> It checks `event.button == 0`, so it responds only for primary mouse click.
> 
> while I prefer checking `event.button` for all those links like this (see
> bug 1297170) tho, at least those links should behave consistently.
Attachment #8789970 - Flags: review?(jaws)
Assignee: nobody → fliu
Status: NEW → ASSIGNED
Comment on attachment 8789970 [details]
Bug 1301813 - "Change preferences for search engine suggestions..." doesn't respond to secondary mouse clicking in about:preferences, Privacy pane

https://reviewboard.mozilla.org/r/77988/#review76678
Attachment #8789970 - Flags: review?(jaws) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/2f19e23bab67
"Change preferences for search engine suggestions..." doesn't respond to secondary mouse clicking in about:preferences, Privacy pane. r=jaws
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2f19e23bab67
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
I have reproduced this bug with Nightly 51.0a1 (2016-09-09) (32-bit) on Windows 8.1(64-Bit).

This bug's fix is verified on Latest Aurora 51.0a2.
Build ID : 20160929004005
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160928]
Based on comment 8, I will set the corresponding flags.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.