1297246 - [linux] browser chrome does not honor OS color theme for some (KDE?) themes

Status: NEW

(Core :: Widget: Gtk, defect, P3)

Description

[Joshua Hudson]

Attachment: firefox48.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160210153822

Steps to reproduce:

Have: Linux
Have: KDE
Have: A dark color theme loaded
Opened browser



Actual results:

browser tab area is black text / white background


Expected results:

browser tab area is white text / dark grey background
This is an accessibility case

Comment 1

[Joshua Hudson]

Attachment: firefox44.png

Windows x86 is not affected.

Comment 2

[Tooru Fujisawa [:arai]]

Can you clarify "Have: A dark color theme loaded" part?
Where do you configure it and which specific theme?

Also, does the issue happen on safe mode and clean profile?

Comment 3

[:Gijs (he/him)]

arai's questions are spot on. FWIW, this works for me with arc-dark on ubuntu when using gtk/gnome, so more details about your desktop environment and theme (and gtk 3 version) would be helpful. Given that it works with other desktop themes, I expect the styling of the browser theme is fine and there's an issue with our widget/gtk implementation that's supposed to read these names from themes. That, or maybe the KDE theme you've configured is somehow not providing dark colours to gtk3 apps? That would also explain the difference (but wouldn't be a Firefox bug).

Comment 4

[Joshua Hudson]

OUCH! The whole browser is so bright it hurts my eyes when started on a clean profile. Even the create profile window did not pick up the color theme.

I think I have KDE Revision 4.12 (2013-11-05) but it's possible Debian Jesse has mixed packages.

Color theme selected: K -> Search -> Colors -> Scheme -> Obsidian Coast

Anyway I hold bug to be in Firefox because Firefox 44 works properly but immediately broken on upgrade to Firefox 48.

Comment 5

[Tooru Fujisawa [:arai]]

Thanks, I confirmed the issue on the following configuration:
  * Debian 8.5 (Linux 3.16.0.4-amd64)
  * GTK 3.14.5-1+deb8u1
  * KDE 4.14.2
  * KDE's Obsidian Coast theme

Here's regression range (it happens from 42 on nightly):
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8e5c888d0d89&tochange=1f77b78797d6

there's GTK+3 switch (bug 1186003)

Comment 7

[Karl Tomlinson (:karlt)]

It may be necessary to set the GTK3 theme, but bug 1216658 means many dark themes will not be used with the environment variable from bug 1272332.

Comment 8

[Karl Tomlinson (:karlt)]

It may be necessary to set the GTK3 theme, but bug 1216658 means many dark themes will not be used if the environment variable from bug 1272332 is not set.

Comment 10

[Joshua Hudson]

So we now have a workaround;

1) Have a GTK3 dark theme such as Adwaita:dark 

2) Set env:

GTK_THEME=Adwaita:dark
MOZ_ALLOW_GTK_DARK_THEME=true

It still doesn't pick up the host KDE theme no matter what I do. I can't get the gnome theme editor to do anything other than crash so depending on working gnome themes is not as bright as it sounds.