Closed Bug 1297276 Opened 4 years ago Closed 4 years ago

Rename mfbt/unused.h to mfbt/Unused.h for consistency

Categories

(Core :: MFBT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: kanru, Assigned: kanru)

References

Details

Attachments

(1 file, 1 obsolete file)

Since the object is renamed to Unused, it's logical to rename the header too. All other headers under mfbt are Capitalized and has matching class name.
Notes:
- These sort of things might require a clobber (renaming a file with a different case)
- These two patches should *not* be autolanded, but folded before landing.
(In reply to Mike Hommey [:glandium] from comment #3)
> Notes:
> - These sort of things might require a clobber (renaming a file with a
> different case)

Thanks for the reminder. I'll change CLOBBER in case someone is building on case insensitive file system. Do we support that?

> - These two patches should *not* be autolanded, but folded before landing.

Yes, the split is only to make the review easier.
We don't have conditional clobbers.
(In reply to Mike Hommey [:glandium] from comment #5)
> We don't have conditional clobbers.

I mean, do we support building on a case insensitive file system? I guess yes.
Considering Windows is case insensitive and you can't do anything about it, yes. Mac is also case insensitive by default.
hooray!
Blocks: 1297315
Comment on attachment 8783804 [details]
Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency.

https://reviewboard.mozilla.org/r/73484/#review71432
Attachment #8783804 - Flags: review?(nfroyd) → review+
Comment on attachment 8783805 [details]
Bug 1297276 - Update all places using mozilla/unused.h

https://reviewboard.mozilla.org/r/73486/#review71434

r=me with Mike's caveats addressed when this patch lands.
Attachment #8783805 - Flags: review?(nfroyd) → review+
Attachment #8783805 - Attachment is obsolete: true
Pushed by kchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/564549c354b0
Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
I figured you might want to know this too.
Flags: needinfo?(jorgk)
Thanks, much appreciated.

Looks like we're not using it though:
https://dxr.mozilla.org/comm-central/search?q=unused.h&redirect=false
(I had it in a patch, but the reviewers made me take it out and replace it with real error checking.)
Flags: needinfo?(jorgk)
https://hg.mozilla.org/mozilla-central/rev/564549c354b0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ec654ccc2e0f
Fix another instance of mozilla/unused.h that snuck in.
(In reply to Mike Hommey [:glandium] from comment #7)
> Considering Windows is case insensitive and you can't do anything about it,
> yes. Mac is also case insensitive by default.

This patch prevents people from doing |git pull -f| to get their head updated. I workaround it by |rm mtbf/unused*|. Do you think it make sense to send out a note to dev-platform and/or firefox-dev on that?
Flags: needinfo?(kchen)
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #19)
> (In reply to Mike Hommey [:glandium] from comment #7)
> > Considering Windows is case insensitive and you can't do anything about it,
> > yes. Mac is also case insensitive by default.
> 
> This patch prevents people from doing |git pull -f| to get their head
> updated. I workaround it by |rm mtbf/unused*|. Do you think it make sense to
> send out a note to dev-platform and/or firefox-dev on that?

Thanks, done.
Flags: needinfo?(kchen)
Assignee: nobody → kchen
You need to log in before you can comment on or make changes to this bug.