1297311 - Remove MediaDataDecoder::ConfigurationChanged API and ensure decoders are only ever created once extradata is known

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Jean-Yves Avenard [:jya]]

For the Windows and Gonk decoder, we feed AnnexB type data letting the decoder handle in-band SPS/PPS NAL.

For the other decoders, they are wrapped in a H264Converter wrapper that monitor the input stream for the SPS NAL; and only instantiate a new decoder once this extradata has been extracted.

The MediaFormatReader now always create a new decoder whenever the resolution change. We do not rely on the decoders being able to handle change of resolutions.

We can remove this. We would have to also wrap annexB decoder in the H264Converter.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1297311: P1. Always recreate a decoder when SPS changes.

This allow consistency between platforms. A decoder will now always be shutdown and another one created if the video configuration changes.

Review commit: https://reviewboard.mozilla.org/r/81006/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81006/

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1297311: P2. Remove redundant virtual keyword.

Review commit: https://reviewboard.mozilla.org/r/81008/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81008/

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8794691 [details]
Bug 1297311: P2. Remove redundant virtual keyword.

https://reviewboard.mozilla.org/r/81008/#review79632

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8794690 [details]
Bug 1297311: P1. Always recreate a decoder when SPS changes.

https://reviewboard.mozilla.org/r/81006/#review79636

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19e901487418
P1. Always recreate a decoder when SPS changes. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/74cc37d7da2c
P2. Remove redundant virtual keyword. r=mattwoodrow

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/19e901487418
https://hg.mozilla.org/mozilla-central/rev/74cc37d7da2c