Remove MediaDataDecoder::ConfigurationChanged API and ensure decoders are only ever created once extradata is known

RESOLVED FIXED in Firefox 52

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
For the Windows and Gonk decoder, we feed AnnexB type data letting the decoder handle in-band SPS/PPS NAL.

For the other decoders, they are wrapped in a H264Converter wrapper that monitor the input stream for the SPS NAL; and only instantiate a new decoder once this extradata has been extracted.

The MediaFormatReader now always create a new decoder whenever the resolution change. We do not rely on the decoders being able to handle change of resolutions.

We can remove this. We would have to also wrap annexB decoder in the H264Converter.
Depends on: 1288618
Priority: -- → P3
No longer depends on: 1288618
Blocks: 1300677
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Assignee: nobody → jyavenard
(Assignee)

Updated

2 years ago
Attachment #8794690 - Flags: review?(cpearce)
(Assignee)

Updated

2 years ago
Attachment #8794690 - Flags: review?(cpearce)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8794691 [details]
Bug 1297311: P2. Remove redundant virtual keyword.

https://reviewboard.mozilla.org/r/81008/#review79632
Attachment #8794691 - Flags: review?(matt.woodrow) → review+

Comment 4

2 years ago
mozreview-review
Comment on attachment 8794690 [details]
Bug 1297311: P1. Always recreate a decoder when SPS changes.

https://reviewboard.mozilla.org/r/81006/#review79636
Attachment #8794690 - Flags: review?(cpearce) → review+

Comment 5

2 years ago
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19e901487418
P1. Always recreate a decoder when SPS changes. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/74cc37d7da2c
P2. Remove redundant virtual keyword. r=mattwoodrow

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/19e901487418
https://hg.mozilla.org/mozilla-central/rev/74cc37d7da2c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
(Assignee)

Updated

2 years ago
Depends on: 1314863
You need to log in before you can comment on or make changes to this bug.