Closed
Bug 1300677
Opened 8 years ago
Closed 8 years ago
Implement IsHardwareAccelerated and SetSeekThreshold for RemoteVideoDecoder.
Categories
(Core :: Audio/Video: Playback, defect, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(2 files)
5.50 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
2.75 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Currently these just use the default (empty) implementations, but they are implemented properly for WMF, so we really need them to be implemented over IPC.
The latter two just need to be added to PVideoDecoder and hooked up, should be very easy.
IsHardwareAccelerated for WMF looks to be racy at the moment, we're not posting a message to the decoder thread (since it's a sync call) and instead just accessing values from the reader task queue directly.
It might be best to return the required values in the InitComplete message on PVideoDecoder, and cache them locally in RemoteVideoDecoder. We might need an extra message for the host to send if these values ever change.
Updated•8 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•8 years ago
|
||
ConfigurationChanged no longer exists.
Summary: Implement IsHardwareAccelerated, ConfigurationChanged and SetSeekThreshold for RemoteVideoDecoder. → Implement IsHardwareAccelerated and SetSeekThreshold for RemoteVideoDecoder.
Assignee | ||
Comment 2•8 years ago
|
||
Assignee: nobody → matt.woodrow
Attachment #8795953 -
Flags: review?(dvander)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8795954 -
Flags: review?(dvander)
Attachment #8795953 -
Flags: review?(dvander) → review+
Attachment #8795954 -
Flags: review?(dvander) → review+
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b12b8e293fa
Implement SetSeekThreshold for RemoteVideoDecoder. r=dvander
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ecfeff44ff5
Implement IsHardwareAccelerated for RemoteVideoDecoder. r=dvander
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3b12b8e293fa
https://hg.mozilla.org/mozilla-central/rev/4ecfeff44ff5
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•