Closed
Bug 1297580
Opened 8 years ago
Closed 8 years ago
Bump gap threshold to 500ms
Categories
(Core :: Audio/Video: Playback, defect, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla51
People
(Reporter: jya, Assigned: jya)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
There are various cases of poorly muxed videos where we have greater gaps than the 125ms threshold we allow. We should bump this value to 500ms instead which seems to be a good compromise. Going for greater than 700ms would cause many web-platform-tests to fail as they use segments that are 700ms long and test that having a single media segment missing does cause a stall.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•8 years ago
|
||
wonder why it's not setting the r? values properly...
Assignee | ||
Updated•8 years ago
|
Attachment #8784233 -
Flags: review?(gsquelart)
Attachment #8784234 -
Flags: review?(gsquelart)
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8784232 [details] Bug 1297580: P1. Remove broken optimisation in IntervalSet. https://reviewboard.mozilla.org/r/73762/#review71616
Attachment #8784232 -
Flags: review?(gsquelart) → review+
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8784233 [details] Bug 1297580: [MSE] P2. Halves the fuzz value when checking if seek target is present. https://reviewboard.mozilla.org/r/73764/#review71618
Attachment #8784233 -
Flags: review?(gsquelart) → review+
Comment 7•8 years ago
|
||
mozreview-review |
Comment on attachment 8784234 [details] Bug 1297580: [MSE] P3. Increase gap threshold to 500ms. https://reviewboard.mozilla.org/r/73766/#review71620
Attachment #8784234 -
Flags: review?(gsquelart) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8784234 -
Flags: review?(ajones)
Comment 9•8 years ago
|
||
mozreview-review |
Comment on attachment 8784603 [details] Bug 1297580: [MSE] P4. Add mochitest. https://reviewboard.mozilla.org/r/73962/#review71846
Attachment #8784603 -
Flags: review?(gsquelart) → review+
Comment 10•8 years ago
|
||
mozreview-review |
Comment on attachment 8784234 [details] Bug 1297580: [MSE] P3. Increase gap threshold to 500ms. https://reviewboard.mozilla.org/r/73766/#review71888
Attachment #8784234 -
Flags: review?(ajones) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Comment 15•8 years ago
|
||
Pushed by jyavenard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3fe525095a25 P1. Remove broken optimisation in IntervalSet. r=gerald https://hg.mozilla.org/integration/autoland/rev/33e9d496b8be [MSE] P2. Halves the fuzz value when checking if seek target is present. r=gerald https://hg.mozilla.org/integration/autoland/rev/c251ec47067b [MSE] P3. Increase gap threshold to 500ms. r=gerald,kentuckyfriedtakahe https://hg.mozilla.org/integration/autoland/rev/c84540c8e42d [MSE] P4. Add mochitest. r=gerald
Updated•8 years ago
|
Priority: -- → P3
Comment 16•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3fe525095a25 https://hg.mozilla.org/mozilla-central/rev/33e9d496b8be https://hg.mozilla.org/mozilla-central/rev/c251ec47067b https://hg.mozilla.org/mozilla-central/rev/c84540c8e42d
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment 17•8 years ago
|
||
Seems that we don't want to uplift that to 50, marking it as wontfix.
Assignee | ||
Comment 18•8 years ago
|
||
why not? who doesn't want to uplift that to 50? just being curious?
Comment 19•8 years ago
|
||
My rational is kind of lame: the patches landed about 2 weeks ago and you didn't requested the uplift :)
You need to log in
before you can comment on or make changes to this bug.
Description
•