Closed Bug 1297580 Opened 8 years ago Closed 8 years ago

Bump gap threshold to 500ms

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox48 --- wontfix
firefox49 --- wontfix
firefox50 --- affected
firefox51 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

There are various cases of poorly muxed videos where we have greater gaps than the 125ms threshold we allow.

We should bump this value to 500ms instead which seems to be a good compromise.

Going for greater than 700ms would cause many web-platform-tests to fail as they use segments that are 700ms long and test that having a single media segment missing does cause a stall.
Blocks: 1284331
wonder why it's not setting the r? values properly...
Attachment #8784233 - Flags: review?(gsquelart)
Attachment #8784234 - Flags: review?(gsquelart)
Comment on attachment 8784232 [details]
Bug 1297580: P1. Remove broken optimisation in IntervalSet.

https://reviewboard.mozilla.org/r/73762/#review71616
Attachment #8784232 - Flags: review?(gsquelart) → review+
Comment on attachment 8784233 [details]
Bug 1297580: [MSE] P2. Halves the fuzz value when checking if seek target is present.

https://reviewboard.mozilla.org/r/73764/#review71618
Attachment #8784233 - Flags: review?(gsquelart) → review+
Comment on attachment 8784234 [details]
Bug 1297580: [MSE] P3. Increase gap threshold to 500ms.

https://reviewboard.mozilla.org/r/73766/#review71620
Attachment #8784234 - Flags: review?(gsquelart) → review+
See Also: → 1284700
Attachment #8784234 - Flags: review?(ajones)
Comment on attachment 8784234 [details]
Bug 1297580: [MSE] P3. Increase gap threshold to 500ms.

https://reviewboard.mozilla.org/r/73766/#review71888
Attachment #8784234 - Flags: review?(ajones) → review+
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3fe525095a25
P1. Remove broken optimisation in IntervalSet. r=gerald
https://hg.mozilla.org/integration/autoland/rev/33e9d496b8be
[MSE] P2. Halves the fuzz value when checking if seek target is present. r=gerald
https://hg.mozilla.org/integration/autoland/rev/c251ec47067b
[MSE] P3. Increase gap threshold to 500ms. r=gerald,kentuckyfriedtakahe
https://hg.mozilla.org/integration/autoland/rev/c84540c8e42d
[MSE] P4. Add mochitest. r=gerald
Depends on: 1298606
Seems that we don't want to uplift that to 50, marking it as wontfix.
why not? who doesn't want to uplift that to 50? just being curious?
My rational is kind of lame: the patches landed about 2 weeks ago and you didn't requested the uplift :)
You need to log in before you can comment on or make changes to this bug.