Bump gap threshold to 500ms

RESOLVED FIXED in Firefox 51

Status

()

P3
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks: 1 bug)

unspecified
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 wontfix, firefox49 wontfix, firefox50 affected, firefox51 fixed)

Details

Attachments

(4 attachments)

(Assignee)

Description

3 years ago
There are various cases of poorly muxed videos where we have greater gaps than the 125ms threshold we allow.

We should bump this value to 500ms instead which seems to be a good compromise.

Going for greater than 700ms would cause many web-platform-tests to fail as they use segments that are 700ms long and test that having a single media segment missing does cause a stall.
(Assignee)

Updated

3 years ago
Blocks: 1284331
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 4

3 years ago
wonder why it's not setting the r? values properly...
(Assignee)

Updated

3 years ago
Attachment #8784233 - Flags: review?(gsquelart)
Attachment #8784234 - Flags: review?(gsquelart)

Comment 5

3 years ago
mozreview-review
Comment on attachment 8784232 [details]
Bug 1297580: P1. Remove broken optimisation in IntervalSet.

https://reviewboard.mozilla.org/r/73762/#review71616
Attachment #8784232 - Flags: review?(gsquelart) → review+

Comment 6

3 years ago
mozreview-review
Comment on attachment 8784233 [details]
Bug 1297580: [MSE] P2. Halves the fuzz value when checking if seek target is present.

https://reviewboard.mozilla.org/r/73764/#review71618
Attachment #8784233 - Flags: review?(gsquelart) → review+

Comment 7

3 years ago
mozreview-review
Comment on attachment 8784234 [details]
Bug 1297580: [MSE] P3. Increase gap threshold to 500ms.

https://reviewboard.mozilla.org/r/73766/#review71620
Attachment #8784234 - Flags: review?(gsquelart) → review+
(Assignee)

Updated

3 years ago
See Also: → bug 1284700
Comment hidden (mozreview-request)
(Assignee)

Updated

3 years ago
Attachment #8784234 - Flags: review?(ajones)

Comment 9

3 years ago
mozreview-review
Comment on attachment 8784603 [details]
Bug 1297580: [MSE] P4. Add mochitest.

https://reviewboard.mozilla.org/r/73962/#review71846
Attachment #8784603 - Flags: review?(gsquelart) → review+
Comment on attachment 8784234 [details]
Bug 1297580: [MSE] P3. Increase gap threshold to 500ms.

https://reviewboard.mozilla.org/r/73766/#review71888
Attachment #8784234 - Flags: review?(ajones) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

3 years ago
status-firefox48: --- → wontfix
status-firefox49: --- → affected
status-firefox50: --- → affected

Comment 15

3 years ago
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3fe525095a25
P1. Remove broken optimisation in IntervalSet. r=gerald
https://hg.mozilla.org/integration/autoland/rev/33e9d496b8be
[MSE] P2. Halves the fuzz value when checking if seek target is present. r=gerald
https://hg.mozilla.org/integration/autoland/rev/c251ec47067b
[MSE] P3. Increase gap threshold to 500ms. r=gerald,kentuckyfriedtakahe
https://hg.mozilla.org/integration/autoland/rev/c84540c8e42d
[MSE] P4. Add mochitest. r=gerald

Comment 16

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3fe525095a25
https://hg.mozilla.org/mozilla-central/rev/33e9d496b8be
https://hg.mozilla.org/mozilla-central/rev/c251ec47067b
https://hg.mozilla.org/mozilla-central/rev/c84540c8e42d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(Assignee)

Updated

3 years ago
Depends on: 1298606
Seems that we don't want to uplift that to 50, marking it as wontfix.
status-firefox49: affected → wontfix
status-firefox50: affected → wontfix
(Assignee)

Comment 18

3 years ago
why not? who doesn't want to uplift that to 50? just being curious?
My rational is kind of lame: the patches landed about 2 weeks ago and you didn't requested the uplift :)
status-firefox50: wontfix → affected
You need to log in before you can comment on or make changes to this bug.