1297750 - Uplift a couple of PDF Viewer UI regression fixes to Firefox 49

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Brendan Dahl [:bdahl]]

This patch uplifts the following PRs:
 1. #7463 - Add back moz-specific fullscreen support code for ´MOZCENTRAL` builds (bug 1268749, PR 7273 follow-up)
 2. #7458 - Consolidate updating of various Toolbar state (e.g. page and scale) in one method in PDFViewerApplication
 3. #7485 - Ensure that we don't reset the current page view if the user inputs an invalid page number (PR 7289 follow-up)
 
Without these patches, the following things will *not* work in the PDF Viewer in Firefox 49:
 1. The Presentation Mode will be completely disabled.
 2. The Previous/Next (and First/Last Page) buttons will not be initialized correctly when the viewer loads.
 3. The viewer will not behave correctly if the user accidentally enters a non-existent Page Number in the UI.

Comment 1

[Brendan Dahl [:bdahl]]

Attachment: bug1297750.diff

Waiting on try https://treeherder.mozilla.org/#/jobs?repo=try&revision=5291f9c9f387

Comment 2

[Brendan Dahl [:bdahl]]

Try harder: https://treeherder.mozilla.org/#/jobs?repo=try&revision=34691988eb14

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Brendan, can you request uplift ? This can still make the beta 9 build on Thursday.

Comment 4

[Jonas Jenwald [:Snuffleupagus]]

Comment on attachment 8784468 [details] [diff] [review]
bug1297750.diff

Approval Request Comment
[Feature/regressing bug #]: Regressed in bug 1268706, and bug 1272518.
[User impact if declined]: Without this patch, the following things will *not* work in the PDF Viewer in Firefox 49:
  1. The Presentation Mode will be completely disabled.
  2. The Previous/Next (and First/Last Page) buttons will not be initialized correctly when the viewer loads.
  3. The viewer will not behave correctly if the user accidentally enters a non-existent Page Number in the UI.

[Describe test coverage new/current, TreeHerder]: Manual testing and existing PDF integration tests on TreeHerder.
[Risks and why]: Low, this is already present in the upstream PDF.js GitHub repo, on mozilla-central, and on mozilla-aurora.
[String/UUID change made/needed]: None

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8784468 [details] [diff] [review]
bug1297750.diff

Fix for several regressions from 49, let's land this for beta 9 so we can test before release.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/312c81362c08

Comment 7

[Cornel Ionce [:noni] [Hubs QA]]

Performed exploratory testing using Fx 49.0 build ID 20160905130425 to make sure that the uplifted functionality works as desired.

No issues were found during testing on Windows 10x64, Ubuntu 12.04 x86 and Mac OS X 10.11.6. 

Closing this issue.