1299138 - The Presentation mode button is missing from the PDF files

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Mihai Boldan, QA [:mboldan]]

[Affected versions]:
- Firefox 49.0b1, Firefox 49.0b8

[Affected platforms]:
- Windows 10X64, Mac OS x 10.10.5, Ubuntu 14.04 x86

[Steps to reproduce]:
1. Launch Firefox.
2. Open http://www23.statcan.gc.ca/imdb-bmdi/pub/instrument/3901_Q2_V3-eng.pdf .

[Expected result]:
- The Presentation Mode button is displayed in the toolbar.

[Actual result]:
- The Presentation Mode button is not displayed in the toolbar. (https://i.imgur.com/F8H6WlI.png)

[Regression range]:
- I think that Bug 1277914 caused this issue.

[Additional notes]:
- The issue is not reproducible on Firefox 48 RC, Latest Aurora or on Latest Nightly builds.

Comment 1

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

I don't think this has to block 49 beta 8. But I think we should fix it before release. 
Is that realistic to do?  Or, should we downgrade to the last version of pdf.js? 
The beta 9 build should start this Thursday. 

Brendan, is this still a project you work on? If not, who would you suggest?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Is that what bug 1297750 is tracking? It's marked as a dep here.

Comment 3

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Thanks Ryan, I didn't notice that part, looks like you are right.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

The fix for this just landed on Beta over in bug 1297750. Can you please verify that things work as expected on builds containing that fix? Thanks!

Comment 5

[Mihai Boldan, QA [:mboldan]]

The issue is no longer reproducible on Firefox 49.0b9(20160830170722) tinderbox build.
Tests were performed under Windows 10x64, Mac OS X 10.10.5 and under Ubuntu 16.04x64.

I am not marking this issue Verified Fixed until the 49.0b9 official build will be released. 
Also, I am not removing the ni until the fix will be confirmed on the official build.

Comment 6

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Marking this fixed for 49 since the patch landed in bug 1297750.

Comment 7

[Mihai Boldan, QA [:mboldan]]

I am marking this issue Verified Fixed since is no longer reproducible on Firefox 49.0b9, under Windows 10x64, Mac OS X 10.11.1, or under Ubuntu 16.04x64.