1297753 - Release 49 - configure list for addons/e10s expansion

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect, P1)

Description

[:shell escalante]

whatever the decision about the list is, we need to file a bug to get the list configured for release, because it's only set up for beta and it doesn't automatically roll to the release channel (because the code is conditioned on the channel name).  (It's a very simple change)

Comment 1

[Erin Lancaster [:elan]]

Shell and I landed on a milestone for the Go/No-Go: Aug 30 (Beta 8). 

(1) The Add-Ons included in the experiment: https://docs.google.com/spreadsheets/d/1zE1TNV0z6gaYgugBAns3XXDexLDHAa2Dmj0EVQIg8tc/edit#gid=0

(+) Add-Ons written as WebExtension: arewee10syet.com

Comment 2

[:shell escalante]

Hi Felipe, based on Friday's talk - for initial roll-out we'd just want:

Video download helper	5.6.1 (or higher)	{b9db16a4-6edc-47ec-a1f4-b86292ed211d}
Adblock Plus	        2.7.3 (or higher)	{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}
Emoji cheatsheet 	1.1.1 (or higher)	jid1-Xo5SuA6qc1DFpw@jetpack
Awesome Screenshot Plus	3.0.10 (or higher)	jid0-GXjLLfbCoAx0LcltEdFrEkQdQPI@jetpack

Comment 3

[:shell escalante]

that way we can add in add-ons later in release, since there won't be throttling.  it gets the Discovery Pane add-ons in the experiment first.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Chutten, how hard would it be to run the longitudinal analysis you did of the addon users on release, but now only including these 4 addons instead of the 9 from the full list?

Comment 5

[:shell escalante]

sorry Felipe - need to add one more to the initial list - so there will be 5 add-ons that go out with Beta 49 (provided we get the 100% go in the meeting tomorrow)...(the top, new one is one we wrote at Mozilla and tested to help with e10s)

Add-on compatibility Reporter 2.2.0 (or higher) [e-mail]
Video download helper	5.6.1 (or higher)	b9db16a4-6edc-47ec-a1f4-b86292ed211d
Adblock Plus	        2.7.3 (or higher)	d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d
Emoji cheatsheet 	1.1.1 (or higher)	jid1-Xo5SuA6qc1DFpw@jetpack
Awesome Screenshot Plus	3.0.10 (or higher)	jid0-GXjLLfbCoAx0LcltEdFrEkQdQPI@jetpack

Comment 6

[Chris H-C :chutten|PTO (back July 13)]

According to longitudinal[1], 2.7% of users on release have addons that are only on :shell's list from comment 5 (plus hello, pocket, e10s rollout, and any non-extension-type addons).

[1]:
A = # of clients with previously-ineligible addons: https://sql.telemetry.mozilla.org/queries/1105/source
B = # of clients with now-ineligible addons: https://sql.telemetry.mozilla.org/queries/1021/source#table
C = # of clients on release in longitudinal: https://sql.telemetry.mozilla.org/queries/1106/source

(A - B) / C is 2.7%

Comment 7

[:shell escalante]

Thanks chutten - based on that info and in the go/no-go meeting where we all were (felipe, chutten, bds, erin, brad, jimm, shell, sylvestre, lizzard)... we will go with the same cohort as in beta plus one add-on (that has passed softvision)...

Add-on compatibility Reporter 2.2.0 (or higher) [e-mail]

logic for going with all is that we need ABP in the first part because of being in the Discovery Pane (a parallel effort to drive good first experience of add-ons for new users).  

Add-on compatibility Reporter has passed softvision testing. it is one we just wrote to help with user visibility on if add-ons are marked as compatible or not and e10s feedback capability.

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1297753 - Configure list of add-ons for e10s rollout on release 49.

Review commit: https://reviewboard.mozilla.org/r/76398/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76398/

Comment 9

[:Felipe Gomes (needinfo for replies!)]

I did some clean-up and removed set 1 which was never used.

The limited set comes from comment 5 and let us quickly change to it through the system add-on, in case something comes up.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8787707 [details]
Bug 1297753 - Configure list of add-ons for e10s rollout on release 49.

https://reviewboard.mozilla.org/r/76398/#review74492

r=me, though there's some busted JS in here which makes me want to suggest really making sure that this add-on is booting itself properly after fixing that before landing.

::: toolkit/mozapps/extensions/internal/E10SAddonsRollout.jsm:50
(Diff revision 1)
>    "ASP": { // Awesome Screenshot Plus
>      id: "jid0-GXjLLfbCoAx0LcltEdFrEkQdQPI@jetpack", minVersion: "3.0.10",
>    },
>  
> -  "PersonasPlus": {
> +  "PersonasPlus": { // PersonasPlus
>      id: "[e-mail]", minVersion: "1.8.0",

TIL our CEO wrote PersonasPlus! Or at least had it put under his namespace. Neat. :)

::: toolkit/mozapps/extensions/internal/E10SAddonsRollout.jsm:55
(Diff revision 1)
>      id: "[e-mail]", minVersion: "1.8.0",
>    },
>  
> +  "ACR": { // Add-on Compatibility Reporter
> +    id: "[e-mail]", minVersion: "2.2.0",
> +  }

Missing comma - this is going to break.

Comment 11

[:Felipe Gomes (needinfo for replies!)]

Thanks for catching that! I've got a build going right now to double check

Comment 12

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8787707 [details]
Bug 1297753 - Configure list of add-ons for e10s rollout on release 49.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76398/diff/1-2/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ccfea02bf0f
Configure list of add-ons for e10s rollout on release 49. r=mconley

Comment 14

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8787707 [details]
Bug 1297753 - Configure list of add-ons for e10s rollout on release 49.

Approval Request Comment
[Feature/regressing bug #]: This configures the system add-on to activate e10s for the first add-on cohort on 49.  This is the list of 10 add-ons (+ WebExtensions) that were tested during the beta cycle.  We should take this in mozilla-beta so that it's built with the 49 Release RC.

[User impact if declined]: no add-ons + e10s on 49
[Describe test coverage new/current, TreeHerder]: tested throughout Beta 49
[Risks and why]: more users being activated to e10s
[String/UUID change made/needed]: none

Comment 15

[Liz Henry (:lizzard)]

Comment on attachment 8787707 [details]
Bug 1297753 - Configure list of add-ons for e10s rollout on release 49.

Taking this for the 49 RC build on Monday.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/199036f36668

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/238f82d981fc

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9ccfea02bf0f