Closed Bug 1297773 Opened 8 years ago Closed 8 years ago

Can't profile workers

Categories

(Core :: Gecko Profiler, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(1 file)

you used to be able to profile workers by including 'Worker' in the thread filter. That no longer works.
Assignee: nobody → bgirard
Comment on attachment 8784496 [details]
Bug 1297773 - Fix thread filter to use case insensitive substring matching.

https://reviewboard.mozilla.org/r/73938/#review71794

Should we skip empty filters? Or are they already excluded from the filter list in some other place? Otherwise something like "GeckoMain," can lead to filtering all threads.
Attachment #8784496 - Flags: review?(mstange) → review+
Could be a feature if you want to profile everything actually. I believe an empty list will pick a default set of the thread (Main+Compositor IIRC). This way would allow you to profiling everything, along with the huge performance penalty.
Pushed by b56girard@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cdb8f7fe8a7c
Fix thread filter to use case insensitive substring matching. r=mstange
https://hg.mozilla.org/mozilla-central/rev/cdb8f7fe8a7c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: