1297798 - Pref off full-duplex for Windows in beta

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[Randell Jesup [:jesup] (needinfo me)]

Bug 1295193 implies that full_duplex is causing problem when the input and out rates don't match (perhaps on 3.5" only, though I suspect that part is a red herring).

It's possible this is a manifestation of bug 1297083, which has been fixed and caused similar distortions and delay, but that might just be a coincidence.  Under the assumption this is a full_duplex issue, we should pref off in 49.  I'll wait to land this (for a short time) until I have confirmation about the above possible cause.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: pref off cubeb full_duplex audio on windows for beta rs=jesup

MozReview-Commit-ID: Kgo5q8R5qnw

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8784510 [details] [diff] [review]
pref off cubeb full_duplex audio on windows for beta rs=jesup

Approval Request Comment
[Feature/regressing bug #]: N/A

[User impact if declined]: Some users with mismatch input/output frequencies might have distorted audio and delay

[Describe test coverage new/current, TreeHerder]: Mac is turned off in beta as well, so paths are already largely being tested.

[Risks and why]: very low risk (non-full-duplex is in use in beta for mac and android).  Asking preemptively waiting on confirmation.

[String/UUID change made/needed]: none

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

From discussion on irc sounds like we do want this in beta as soon as possible.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8784510 [details] [diff] [review]
pref off cubeb full_duplex audio on windows for beta rs=jesup

Pref off full duplex on windows since we have found some new issues.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0084d48b8214