Closed
Bug 1297798
Opened 8 years ago
Closed 8 years ago
Pref off full-duplex for Windows in beta
Categories
(Core :: Audio/Video: cubeb, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: jesup, Assigned: jesup)
References
Details
Attachments
(1 file)
1.35 KB,
patch
|
jesup
:
review+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Bug 1295193 implies that full_duplex is causing problem when the input and out rates don't match (perhaps on 3.5" only, though I suspect that part is a red herring). It's possible this is a manifestation of bug 1297083, which has been fixed and caused similar distortions and delay, but that might just be a coincidence. Under the assumption this is a full_duplex issue, we should pref off in 49. I'll wait to land this (for a short time) until I have confirmation about the above possible cause.
Assignee | ||
Updated•8 years ago
|
Rank: 10
Assignee | ||
Comment 1•8 years ago
|
||
MozReview-Commit-ID: Kgo5q8R5qnw
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8784510 [details] [diff] [review] pref off cubeb full_duplex audio on windows for beta rs=jesup Approval Request Comment [Feature/regressing bug #]: N/A [User impact if declined]: Some users with mismatch input/output frequencies might have distorted audio and delay [Describe test coverage new/current, TreeHerder]: Mac is turned off in beta as well, so paths are already largely being tested. [Risks and why]: very low risk (non-full-duplex is in use in beta for mac and android). Asking preemptively waiting on confirmation. [String/UUID change made/needed]: none
Attachment #8784510 -
Flags: review+
Attachment #8784510 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•8 years ago
|
status-firefox49:
--- → affected
Comment 3•8 years ago
|
||
From discussion on irc sounds like we do want this in beta as soon as possible.
Comment 4•8 years ago
|
||
Comment on attachment 8784510 [details] [diff] [review] pref off cubeb full_duplex audio on windows for beta rs=jesup Pref off full duplex on windows since we have found some new issues.
Attachment #8784510 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 5•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/0084d48b8214
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•