1297850 - Remove dead code left after removal of JPZ

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect, P3)

Description

[Randall Barker [:rbarker]]

The removal of JPZ in Bug 1291373 left dead code behind.

Comment 1

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1297850-part-1-Remove-dead-code-left-behind-after-JPZ-removal-16082415-74533f2.patch

Comment 2

[Randall Barker [:rbarker]]

Attachment: 0002-Bug-1297850-part-2-Background-is-no-longer-cleared-by-Java.-Remove-unused-setBackgroundColor-16082415-3c28a79.patch

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/979694026137
part 1, Remove dead code left behind after JPZ removal. r=jchen
https://hg.mozilla.org/integration/mozilla-inbound/rev/e83c9eb279a9
part 2, Background is no longer cleared by Java. Remove unused setBackgroundColor. r=jchen

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

When this landed, robocop tests started failing like https://treeherder.mozilla.org/logviewer.html#?job_id=34655495&repo=mozilla-inbound

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/29f62a5e5273

Comment 5

[Randall Barker [:rbarker]]

(In reply to Wes Kocher (:KWierso) from comment #4)
> When this landed, robocop tests started failing like
> https://treeherder.mozilla.org/logviewer.html#?job_id=34655495&repo=mozilla-
> inbound
> 
> Backed out in
> https://hg.mozilla.org/integration/mozilla-inbound/rev/29f62a5e5273

Based on the stack trace it isn't obvious how the two are related but I will look in to it.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Definitely started with your patches and went away on the backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=api15%20(rc1&fromchange=814753913f49e7065a942e55a85ba8569e3f3874&tochange=29f62a5e52735d44a53071611915b32e0b4e40aa

Comment 7

[Randall Barker [:rbarker]]

(In reply to Wes Kocher (:KWierso) from comment #6)
> Definitely started with your patches and went away on the backout:
> https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-
> searchStr=api15%20(rc1&fromchange=814753913f49e7065a942e55a85ba8569e3f3874&to
> change=29f62a5e52735d44a53071611915b32e0b4e40aa

I figured it out. ProGuard started erroneously stripping out a class. Running on try now to verify.

Comment 8

[Randall Barker [:rbarker]]

Attachment: 0003-Bug-1297850-part-3-Fix-Robocop-breakage-caused-by-proguard-stripping-out-URLMetadata-r-jchen-16082513-10f7d0b.patch

Fix robocop breakage.

Comment 9

[Randall Barker [:rbarker]]

Ran on try with fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7494f8153308

While I'm seeing a number failures, I'm not see the issue that caused the back out so will try and re-land with fix.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2b2bb8abf7b
part 1, Remove dead code left behind after JPZ removal. r=jchen
https://hg.mozilla.org/integration/mozilla-inbound/rev/1641b474f9d3
part 2, Background is no longer cleared by Java. Remove unused setBackgroundColor. r=jchen
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a7524861d8b
part 3, Fix Robocop breakage caused by proguard stripping out URLMetadata r=jchen

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b2b2bb8abf7b
https://hg.mozilla.org/mozilla-central/rev/1641b474f9d3
https://hg.mozilla.org/mozilla-central/rev/9a7524861d8b