Closed Bug 1415297 Opened 2 years ago Closed 2 years ago

Dispatching of TabEvents.LOADED was removed prematurely

Categories

(Firefox for Android :: General, enhancement)

All
Android
enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: JanH, Assigned: JanH, NeedInfo)

References

Details

Attachments

(1 file)

Bug 1297850 removed the Java-side handling of DOMContentLoaded even though both AddToHomeScreenPromotion and the BrowserToolbar were still listening to its TabEvents equivalent (LOADED), with the latter using it for updating of the loading progress bar.
As far as I can tell, because of the missing LOADED event AddToHomeScreenPromotion is currently totally inoperative, so this patch would consequently revive it. As far as I can tell, it's currently still enabled for half of our pre-Release users, so I'm not sure if you want to tweak that value before this patch lands?
Flags: needinfo?(s.kaspari)
Flags: needinfo?(cnevinchen)
I saw that we recently landed a new "Add to home screen" prompt. So I guess we can remove AddToHomeScreenPromotion now? It looks like the new thing doesn't use any of the existing code?
Flags: needinfo?(s.kaspari)
Hi Joe
I think if we've added PWA A2HS feature, we don't need the old "Add to Home Screen Promotion"?
Flags: needinfo?(cnevinchen) → needinfo?(jcheng)
(In reply to Nevin Chen [:nechen] from comment #4)
> Hi Joe
> I think if we've added PWA A2HS feature, we don't need the old "Add to Home
> Screen Promotion"?

If that turns out to be the case, can you disable this in Switchboard and file a follow-up bug to remove the old code?
Flags: needinfo?(cnevinchen)
Comment on attachment 8926092 [details]
Bug 1415297 - Dispatch TabEvents.LOADED again on DOMContentLoaded.

This causes some problems with the event dispatcher and Robocop tests, so needs a little more tweaking (https://treeherder.mozilla.org/#/jobs?repo=try&revision=378a80a96abc40f422304747c34938d4dd0a63bd&selectedJob=143783303)
Attachment #8926092 - Flags: review?(s.kaspari)
Comment on attachment 8926092 [details]
Bug 1415297 - Dispatch TabEvents.LOADED again on DOMContentLoaded.

https://reviewboard.mozilla.org/r/197316/#review208522
Attachment #8926092 - Flags: review?(s.kaspari) → review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/9542e943f100
Dispatch TabEvents.LOADED again on DOMContentLoaded. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/9542e943f100
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
I've filed bug 1421174 for this
Flags: needinfo?(cnevinchen)
You need to log in before you can comment on or make changes to this bug.