1415297 - Dispatching of TabEvents.LOADED was removed prematurely

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Jan Henning [:JanH]]

Bug 1297850 removed the Java-side handling of DOMContentLoaded even though both AddToHomeScreenPromotion and the BrowserToolbar were still listening to its TabEvents equivalent (LOADED), with the latter using it for updating of the loading progress bar.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1415297 - Dispatch TabEvents.LOADED again on DOMContentLoaded.

AddToHomeScreenPromotion uses this for triggering the self-same promotion and
the BrowserToolbar uses it to update its progress display.

Review commit: https://reviewboard.mozilla.org/r/197316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197316/

Comment 2

[Jan Henning [:JanH]]

As far as I can tell, because of the missing LOADED event AddToHomeScreenPromotion is currently totally inoperative, so this patch would consequently revive it. As far as I can tell, it's currently still enabled for half of our pre-Release users, so I'm not sure if you want to tweak that value before this patch lands?

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

I saw that we recently landed a new "Add to home screen" prompt. So I guess we can remove AddToHomeScreenPromotion now? It looks like the new thing doesn't use any of the existing code?

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Hi Joe
I think if we've added PWA A2HS feature, we don't need the old "Add to Home Screen Promotion"?

Comment 5

[Jan Henning [:JanH]]

(In reply to Nevin Chen [:nechen] from comment #4)
> Hi Joe
> I think if we've added PWA A2HS feature, we don't need the old "Add to Home
> Screen Promotion"?

If that turns out to be the case, can you disable this in Switchboard and file a follow-up bug to remove the old code?

Comment 6

[Jan Henning [:JanH]]

Comment on attachment 8926092 [details]
Bug 1415297 - Dispatch TabEvents.LOADED again on DOMContentLoaded.

This causes some problems with the event dispatcher and Robocop tests, so needs a little more tweaking (https://treeherder.mozilla.org/#/jobs?repo=try&revision=378a80a96abc40f422304747c34938d4dd0a63bd&selectedJob=143783303)

Comment 7

[Jan Henning [:JanH]]

Comment on attachment 8926092 [details]
Bug 1415297 - Dispatch TabEvents.LOADED again on DOMContentLoaded.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197316/diff/1-2/

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8926092 [details]
Bug 1415297 - Dispatch TabEvents.LOADED again on DOMContentLoaded.

https://reviewboard.mozilla.org/r/197316/#review208522

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9542e943f100
Dispatch TabEvents.LOADED again on DOMContentLoaded. r=sebastian

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/9542e943f100

Comment 11

[Nevin Chen(Not active on Bugzilla)]

I've filed bug 1421174 for this