1298027 - [EME] Video playback fails when page with EME video is moved into new window

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Ciprian Georgiu, Desktop QA]

Attachment: shaka player bug.gif

[Note]:
- .gif showing the issue

[Affected versions]:
- latest Aurora 50.0a2

[Affected platforms]:
- Windows 10 x86, x64
- Windows 7 x64
- Mac OS X 10.9 (Mavericks)
- Ubuntu 16.04 x64

[Steps to reproduce]:
1. Start Firefox.
2. Go to: http://shaka-player-demo.appspot.com/demo/.
3. From drop-down Asset menu select 'Angel One (multicodec, multilingual, Widevine)'.
4. Click Load.
5. Move the current window (Tab) into New window.

[Expected result]:
- The video continue to play properly in the New window.

[Actual result]:
- The video displays the following error into New window: Shaka Error MEDIA.MEDIA_SOURCE_OPERATION_THREW (InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable)

[Regression range]:
- This is not a regression.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Tested this and it appears to not be WebM specific. I can reproduce this on all released versions. Same steps can be used to reproduce with mp4 or webm media source. Updating bug to reflect broader impact.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

I can repro this on mse-clearkey. NSPR logs show that the CDM is doing a normal shutdown for some reason.

Comment 4

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Updating the name of this bug to reflect that this issue is universal to EME videos, not just those for Shaka.

Comment 5

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1298027 - Relax decoder shutdown and mediakey removal on MediaElement suspension.

This changeset relaxes the shutting down of decoders and removal of mediakeys
when suspending HTMLMediaElements. This should now only happen for adobe
primetime. This alleviates, for non-primetime CDMs, the issue of videos
breaking when moving an EME protected video from a tab to a new window.

These conditions can be relaxed as neither clearkey or widevine support
secure stop. This means we don't need to shutdown their decoders and keys to
signal a stoppage, as at this stage, doing so doesn't give us secure stop and
instead means that playback is busted when we try to resume.

Review commit: https://reviewboard.mozilla.org/r/89488/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89488/

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8805871 [details]
Bug 1298027 - Relax decoder shutdown and mediakey removal on MediaElement suspension.

https://reviewboard.mozilla.org/r/89488/#review88742

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc6a63bedaec
Relax decoder shutdown and mediakey removal on MediaElement suspension. r=cpearce

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fc6a63bedaec

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/37ab1d54a08e
Backed out changeset fc6a63bedaec for timing out in test_eme_stream_capture_blocked_case3.html on Windows 7 opt and pgo. r=backout a=backout

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed this out for timing out in test_eme_stream_capture_blocked_case3.html on Windows 7 opt and pgo:

https://hg.mozilla.org/mozilla-central/rev/37ab1d54a08e7e1431660b22377428b74dcd090a

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fc6a63bedaec6e34bb3b2491b497b4f131387dab
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=5909068&repo=autoland

22:08:19     INFO - [22:03:06.745] 400x300 as-is then 400x300 presented as 533x300-14_case3 stalled
22:08:19     INFO - [22:03:06.856] 400x225-15_case3 stalled
22:08:19     INFO - TEST-UNEXPECTED-FAIL | dom/media/test/test_eme_stream_capture_blocked_case3.html | Test timed out. 
22:08:19     INFO -     reportError@SimpleTest/TestRunner.js:114:7
22:08:19     INFO -     TestRunner._checkForHangs@SimpleTest/TestRunner.js:135:7
22:08:19     INFO -     setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:156:5

Comment 11

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a6c12209cff

Comment 12

[Jim Jeffery not reading bug-mail 1/2/11]

Should this have been re-opened ?

Comment 13

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Yes. I'll reopen while I investigate the test failures.

Comment 14

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Whoops didn't mean to clear that need info. Will hold it while I look at tests.

Comment 15

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea95e24b9ef1

Comment 16

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=74484888d4ed

Comment 17

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1298027 - Shut down CDMs when a containing document becomes inactive.

The previous changeset against this bug relaxed the conditions under which the
CDM and associated objects were shut down. This was to address moving a tab to a
new window breaking EME videos. However, this had the unwanted side effect of
not shutting down those objects early enough when pages are closed.

This changeset introduces a new check to see if the containing document is
currently active, if not we shutdown the CDM. This means CDMs are shutdown on
time, while retaining the desired behaviour that CDMs should not be shut down on
moving tabs to new windows. Shutdowns previously happened because we shut down
if a page hide happened, which took place during a reparent.

Review commit: https://reviewboard.mozilla.org/r/92628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92628/

Comment 18

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 8805871 [details]
Bug 1298027 - Relax decoder shutdown and mediakey removal on MediaElement suspension.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89488/diff/1-2/

Comment 19

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8810270 [details]
Bug 1298027 - Shut down CDMs when a containing document becomes inactive.

https://reviewboard.mozilla.org/r/92628/#review92628

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3930acd16b7
Relax decoder shutdown and mediakey removal on MediaElement suspension. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/0f22052f5c48
Shut down CDMs when a containing document becomes inactive. r=cpearce

Comment 21

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f3930acd16b7
https://hg.mozilla.org/mozilla-central/rev/0f22052f5c48

Comment 22

[Sylvestre Ledru [:Sylvestre]]

Let it ride the train from 53.