With iOS 10 around the corner, this is a good time to finally drop 8 support.
Not requiring these #available checks for iOS 9 will make life easier for bug 1304456, and we'll have to eventually do this anyway, so let's go ahead and knock this one out now.
Created attachment 8793503 [details] [review] Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/2111
Comment on attachment 8793503 [details] [review] Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/2111 Awesome. Thanks for fixing the keychain stuff I missed in the test targets.
Hi Brian, Was there any burden, code-wise, or any compromises we had to make, that we dropped support for iOS 8? I thought it was only the 'if #available' checks that were extra. Just curious, since I'm on iPhone 4s/iOS 8 and don't want to move to iOS 9 as it might slow it down.
Hi Maurya, There's a growing number of features and APIs with each iOS release, so maintaining support for older releases becomes a huge maintenance burden. Examples from iOS 9: * Private browsing * Clearing private data * New XCTest APIs This list will grow longer with iOS 10. Code-wise, we worked around many of these using 'if #available' checks as you said, but maintaining support for 8 means we also need to test and run iOS 8 builds often to make sure they're stable. We were already neglecting iOS 8 before; we just don't have the resources to maintain 8, 9, *and* 10 now.
Hmm, yeah that sounds reasonable. Thanks for your reply!