1298157 - Backout the dll shim work around from bug 1294650

Status: RESOLVED FIXED

(External Software Affecting Firefox :: Other, defect)

Description

[Jim Mathies [:jimm]]

[Tracking Requested - why for this release]:

This fix attempt didn't work, we can back it out.

https://hg.mozilla.org/mozilla-central/rev/d332de446548
https://hg.mozilla.org/releases/mozilla-aurora/rev/a72bfbdf5c9b
https://hg.mozilla.org/releases/mozilla-beta/rev/29dd7d227b7b

Comment 1

[Gerry Chang [:gchang]]

Track 49+/50+/51+ as the fix doesn't work.

Comment 2

[Marco Castelluccio [:marco]]

Maybe the fix didn't work for all users but was a workaround for some of them. A few users in bug 1181091 (and an user in bug 1294650) mention that storing a shim QIPCAP.dll file in the Firefox installation directory fixed the issue for them.

Should we keep the dll shim as a mitigation, even if it doesn't fix the issue for all users? The last times we had similar issues with WebSense (bug 828184 and bug 1181091) we weren't able to do anything but had to wait for a new WebSense release.

Comment 3

[Marco Castelluccio [:marco]]

It doesn't make sense to keep the workaround anymore, since WebSense has fixed the issue and we have a hotfix to prevent people using WebSense from updating.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Jimm, Marco just pointed this out to me. Are you doing the backouts? Should someone else do it? Thanks.

Comment 5

[Jim Mathies [:jimm]]

we don't want to keep this dummy dll in our install.

For backouts, tree managers can handle backing out the appropriate cset on each tree itemized in the first comment.

Comment 6

[u194118]

(In reply to Marco Castelluccio [:marco] from comment #3)
> It doesn't make sense to keep the workaround anymore, since WebSense has
> fixed the issue and we have a hotfix to prevent people using WebSense from
> updating.

well, I still have the old websense version on my professionnal computer, I've already updated to FF 48.0.2 and the workaround works for me... Without a websense update on my computer and with the workaround backout, FF will crash again on my computer with the next version..

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Wes, can you back out the patches in comment 0 so we will have the dummy dll removed for the 49 release candidate build? Thanks.

Comment 8

[Marco Castelluccio [:marco]]

(In reply to jcleval from comment #6)
> well, I still have the old websense version on my professionnal computer,
> I've already updated to FF 48.0.2 and the workaround works for me... Without
> a websense update on my computer and with the workaround backout, FF will
> crash again on my computer with the next version..

You can update WebSense to avoid the crash (they have found the cause and fixed it).

If you aren't able to update before Firefox 49 is released (but you have some time),
you can create a dummy DLL yourself (or just copy the current one from the Firefox
folder and copy it back after the update).

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backouts:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f33d866ca80
https://hg.mozilla.org/releases/mozilla-aurora/rev/3cb50e5df497
https://hg.mozilla.org/releases/mozilla-beta/rev/3d6fce4d6f7b

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f33d866ca80