1298500 - Showing start wizard can't be overridden via distribution

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: First Run, defect)

Description

[Mike Kaply [:mkaply]]

The pref for the start wizard is explicitly written as true:

https://dxr.mozilla.org/mozilla-central/source/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoProfile.java#974

So it can't be overridden at all.

There's no need to explicitly set the preference, just treat it as true if it isn't there.

Comment 1

[Alex Caziuc]

This refers to the first run screen so I'm changing it to First Run component.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Don't set startpage_enabled on profile creation

Now that we have an intent to not show the first run wizard for testing, we should not be explicitly setting the startpage_enabled pref on profile creation.

This allows distributions to turn off the wizard.

I didn't make a change to the first run intent, because it specifically says this:

// Note that we don't set the pref, so subsequent launches can result
// in the firstrun pane being shown.

https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#899

Comment 3

[Chenxia Liu [:liuche]]

Comment on attachment 8786000 [details] [diff] [review]
Don't set startpage_enabled on profile creation

Review of attachment 8786000 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.

::: mobile/android/base/java/org/mozilla/gecko/GeckoProfile.java
@@ -1080,5 @@
>          persistClientId(generateNewClientId());
>  
> -        // Initialize pref flag for displaying the start pane for a new profile.
> -        final SharedPreferences prefs = GeckoSharedPrefs.forProfile(mApplicationContext);
> -        prefs.edit().putBoolean(FirstrunAnimationContainer.PREF_FIRSTRUN_ENABLED, true).apply();

Where was the code where you set this off by default in the distribution code? Just curious.

Comment 4

[Mike Kaply [:mkaply]]

> Where was the code where you set this off by default in the distribution code? Just curious.

We have an AndroidPreferences section where I set startpane_enabled to false.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

This also gets rid of the dependency on the org.mozilla.gecko.firstrun package in GeckoProfile :) Don't forget to remove the `import org.mozilla.gecko.firstrun.FirstrunAnimationContainer` line at the start of GeckoProfile.java!

Comment 6

[Mike Kaply [:mkaply]]

> We have an AndroidPreferences section where I set startpane_enabled to false.

Actually, this doesn't work after all, but I still think this is a good patch.

The reason it doesn't work is because startpane_enabled is queried very early.

New patch coming because of tree reorg

Comment 7

[Mike Kaply [:mkaply]]

Attachment: New patch with removal of dependency and file location change

Carrying over r+

Comment 8

[Mike Kaply [:mkaply]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf134ae84918e0a139fd8bac471791c66c1eb3d4
Bug 1298500 - Don't explicitly set the startpane pref. r=liuche

Comment 9

[Mike Kaply [:mkaply]]

FYI, I tested:

New install.
Second start after install.
The "no wizard" intent.
Start after the "no wizard" intent.

Everything worked as before.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cf134ae84918