[geckoview] Make GeckoView compile

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: nalexander, Assigned: jchen)

Tracking

unspecified
Firefox 51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(3 attachments)

This catch-all ticket tracks handling the last few bits of
https://reviewboard.mozilla.org/r/60478/diff/1#index_header.  For
example, there are some hard-coded references to AboutPages that will
need to be removed or a generalized predicate exposed through
GeckoInterface; some access-privacy restrictions to be lifted; etc.
There's also some constants that need to move into (or out of)
GeckoView, etc.

We might add other little tweaks, like
https://reviewboard.mozilla.org/r/60474/diff/1#index_header, too.
jchen: this is the catch-all for "compile GeckoView".  You can see little tweaks and re-arrangements will be needed.  This definitely depends on Bug 1291383 and Bug 1291384 (and, of course, me getting a geckoview Gradle project somewhere).
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Depends on: 1291383, 1291384
(Assignee)

Updated

2 years ago
Depends on: 1301515
(Assignee)

Updated

2 years ago
Depends on: 1298500
(Assignee)

Comment 2

2 years ago
Created attachment 8789567 [details] [diff] [review]
1. Remove geckoview dependency on certain GeckoApp constants (v1)

Code in geckoview depends on several string constants in GeckoApp.
This patch moves PREFS_OOM_EXCEPTION and ACTION_ALERT_CALLBACK from
GeckoApp to GeckoAppShell, to reverse the dependency. Ideally, we'd want
those constants to not be used or used differently in geckoview code,
but this is a quick workaround for now. GeckoThread uses
GeckoApp.ACTION_HOMESCREEN_SHORTCUT, but that block of code is actually
obsolete, so this patch removes the code block and the dependency.
Attachment #8789567 - Flags: review?(s.kaspari)
(Assignee)

Comment 3

2 years ago
Created attachment 8789568 [details] [diff] [review]
2 .Move restrictions package from geckoview to Fennec (v1)

The restrictions package really belongs in Fennec code rather than in
geckoview code. The move also eliminates some dependency errors because
the restrictions package references some classes in Fennec code.
Attachment #8789568 - Flags: review?(nalexander)
Comment on attachment 8789568 [details] [diff] [review]
2 .Move restrictions package from geckoview to Fennec (v1)

Review of attachment 8789568 [details] [diff] [review]:
-----------------------------------------------------------------

Fine by me.
Attachment #8789568 - Flags: review?(nalexander) → review+
Attachment #8789567 - Flags: review?(s.kaspari) → review+
(Assignee)

Comment 5

2 years ago
Created attachment 8789841 [details] [diff] [review]
3. Don't send viewport flush message (v1)

We used to use it to sync viewport metrics between Gecko and Java, but I
don't think this is needed anymore.
Attachment #8789841 - Flags: review?(snorp)
Comment on attachment 8789841 [details] [diff] [review]
3. Don't send viewport flush message (v1)

Review of attachment 8789841 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I think this was JPZ-related.
Attachment #8789841 - Flags: review?(snorp) → review+

Comment 7

2 years ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/403103b3b865
1. Remove geckoview dependency on certain GeckoApp constants; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/88e521197760
2 .Move restrictions package from geckoview to Fennec; r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/335cdcff54f4
3. Don't send viewport flush message; r=snorp

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/403103b3b865
https://hg.mozilla.org/mozilla-central/rev/88e521197760
https://hg.mozilla.org/mozilla-central/rev/335cdcff54f4
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.