Closed Bug 1298543 Opened 4 years ago Closed 4 years ago

Fix test_prompt_http.html for e10s

Categories

(Toolkit :: Password Manager, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
e10s + ---
firefox51 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

(Blocks 1 open bug)

Details

(Whiteboard: [passwords:tech-debt])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1298193 +++

Follow the same basic scheme as bug 1266618 and bug 1298193.
Comment on attachment 8789275 [details]
Bug 1298543 - Fix test_prompt_http.html for e10s.

https://reviewboard.mozilla.org/r/77572/#review77154

LGTM. MattN clarified in person that we're changing the purpose of this test to basically only ensure that a doorhanger is shown when expected (and is of the right kind), but leaving it to other tests to ensure that the doorhanger works as expected... Splitting up "here's a scenario, does pwmgr offer to save a login" and "when a save-login prompt is show, does it actually save". This also helps with doign testing on Android, which has a different popupnotifications implementation.
Attachment #8789275 - Flags: review?(dolske) → review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/c6edbdd09f30
Fix test_prompt_http.html for e10s. r=Dolske
https://hg.mozilla.org/mozilla-central/rev/c6edbdd09f30
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.