1298543 - Fix test_prompt_http.html for e10s

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P3)

Description

[Matthew N. [:MattN]]

+++ This bug was initially created as a clone of Bug #1298193 +++

Follow the same basic scheme as bug 1266618 and bug 1298193.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1298543 - Fix test_prompt_http.html for e10s.

Don't actually test doorhanger notifications since they are only on the desktop browser and browser chrome tests already check them.

The Android notifyObservers additions aren't used in this patch but I added them for consistency and because we should start to use them for cross-platform tests that check if a doorhanger appears.

Review commit: https://reviewboard.mozilla.org/r/77572/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77572/

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 8789275 [details]
Bug 1298543 - Fix test_prompt_http.html for e10s.

https://reviewboard.mozilla.org/r/77572/#review77154

LGTM. MattN clarified in person that we're changing the purpose of this test to basically only ensure that a doorhanger is shown when expected (and is of the right kind), but leaving it to other tests to ensure that the doorhanger works as expected... Splitting up "here's a scenario, does pwmgr offer to save a login" and "when a save-login prompt is show, does it actually save". This also helps with doign testing on Android, which has a different popupnotifications implementation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6edbdd09f30
Fix test_prompt_http.html for e10s. r=Dolske

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c6edbdd09f30