Closed
Bug 1298685
Opened 8 years ago
Closed 8 years ago
Idendity box focus ring should not be hardcoded black
Categories
(Firefox :: Theme, defect, P3)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: dao, Assigned: Towkir, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: access, Whiteboard: [good first bug][lang=css])
Attachments
(1 file)
|
885 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
This is a leftover from when the identity box used to have a hardcoded white background. It's now transparent and the focus ring should use the text color instead of black. We can achieve that by replacing 'outline: 1px dotted #000;' with just 'outline: 1px dotted;':
https://dxr.mozilla.org/mozilla-central/rev/c724ae8bb7b867b6bc65efa1049c0322457ff4b0/browser/themes/windows/browser.css#1491
https://dxr.mozilla.org/mozilla-central/rev/c724ae8bb7b867b6bc65efa1049c0322457ff4b0/browser/themes/linux/browser.css#1056
|
Assignee | |
Comment 1•8 years ago
|
||
Hi dao,
Hope this fix the issue.
Thanks
|
Reporter | |
Comment 2•8 years ago
|
||
Comment on attachment 8785719 [details] [diff] [review]
focus_ring_color.patch
Thanks!
Attachment #8785719 -
Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/38dc7a15f950
Removed color of Idendity box focus ring; r=dao
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in
before you can comment on or make changes to this bug.
Description
•