1298704 - Crash in nsBlockFrame::GetMinISize - stack overflow caused by AccessibleCaretEventHub::Reflow callback

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Mats Palmgren (inactive)]

This bug was filed from the Socorro interface and is 
report bp-7d0aed6a-35aa-41b9-bc61-9b3892160826.
=============================================================

It looks like AccessibleCaret causes infinite recursion through flushing layout.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1298704 - Use flag to avoid calling AccessibleCaretEventHub::Reflow() recursively.

Review commit: https://reviewboard.mozilla.org/r/74902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/74902/

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 8785831 [details]
Bug 1298704 - Use flag to avoid calling AccessibleCaretEventHub::Reflow() recursively.

https://reviewboard.mozilla.org/r/74902/#review72792

::: layout/base/AccessibleCaretEventHub.h:135
(Diff revision 1)
>    bool mInitialized = false;
>  
> +  // Flag to avoid calling Reflow() callback recursively.
> +  bool mIsInReflowCallback = false;

Nit: perhaps we should move both these bool members to after 'mActiveTouchId' instead? (to avoid spilling due to alignment).

::: layout/base/AccessibleCaretEventHub.cpp:686
(Diff revision 1)
>  
>  NS_IMETHODIMP
>  AccessibleCaretEventHub::ReflowInterruptible(DOMHighResTimeStamp aStart,
>                                               DOMHighResTimeStamp aEnd)
>  {
> -  if (!mInitialized) {
> +  // Defer the error checking in Reflow().

s/in/to/

Comment 3

[Mats Palmgren (inactive)]

Comment on attachment 8785831 [details]
Bug 1298704 - Use flag to avoid calling AccessibleCaretEventHub::Reflow() recursively.

https://reviewboard.mozilla.org/r/74902/#review72796

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8785831 [details]
Bug 1298704 - Use flag to avoid calling AccessibleCaretEventHub::Reflow() recursively.

https://reviewboard.mozilla.org/r/74902/#review72792

> Nit: perhaps we should move both these bool members to after 'mActiveTouchId' instead? (to avoid spilling due to alignment).

Before applying my patch, `sizeof(AccessibleCaretEventHub)` is 128 on my machine. Though adding the flag to after `mInitialized` does not increase its size, but moving both bool members to after `mActiveTouchId` reduces the size from 128 to 120. Yeh!

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8785831 [details]
Bug 1298704 - Use flag to avoid calling AccessibleCaretEventHub::Reflow() recursively.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/74902/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e11d9697af59
Use flag to avoid calling AccessibleCaretEventHub::Reflow() recursively. r=mats

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e11d9697af59