Closed
Bug 1298823
Opened 8 years ago
Closed 7 years ago
Make Request constructor throw less often
Categories
(Core :: DOM: Core & HTML, defect, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: bkelly, Assigned: baku)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-needed)
Attachments
(1 file)
4.26 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
The spec is being updated to throw less often from the Request constructor: https://github.com/whatwg/fetch/issues/245
Reporter | ||
Comment 1•8 years ago
|
||
But the spec is still being decided.
Updated•8 years ago
|
Priority: -- → P3
Comment 2•7 years ago
|
||
The spec was updated in https://github.com/whatwg/fetch/pull/377, and I've submitted test changes to account for it in https://github.com/w3c/web-platform-tests/pull/4341 .
Reporter | ||
Comment 3•7 years ago
|
||
We should implement this before chrome if we can to avoid compat problems. Andrew, another one to prioritize if we can.
Flags: needinfo?(overholt)
Comment 4•7 years ago
|
||
baku, can you handle this?
Flags: needinfo?(overholt) → needinfo?(amarchesini)
Reporter | ||
Comment 5•7 years ago
|
||
This might be better described by bug 1341223 now.
Assignee | ||
Comment 6•7 years ago
|
||
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8841939 -
Flags: review?(kyle)
Updated•7 years ago
|
Attachment #8841939 -
Flags: review?(kyle) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7a11dda7af71 Make Request constructor throw less often, r=qdot
Reporter | ||
Comment 8•7 years ago
|
||
Andrea, why does this one still fail? https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/meta/fetch/api/policies/referrer-origin-service-worker.https.html.ini#4
Status: NEW → ASSIGNED
Flags: needinfo?(amarchesini)
Assignee | ||
Comment 9•7 years ago
|
||
simply because my local repo was older than that file. I'll remove that file as well.
Flags: needinfo?(amarchesini)
Comment 11•7 years ago
|
||
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f2606ea1b31d Make Request constructor throw less often, r=me, CLOSED TREE
Backed these out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=80684506&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/2b4713a7a082
Comment 13•7 years ago
|
||
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6d0ac4c74fd5 Make Request constructor throw less often, r=qdot
Comment 14•7 years ago
|
||
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8a5b7f743d66 Backed out changeset 6d0ac4c74fd5 for frequent failures in test_request.html
Comment 15•7 years ago
|
||
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/36730ac6b59f Make Request constructor throw less often, r=qdot
Reporter | ||
Updated•7 years ago
|
Keywords: dev-doc-needed
Comment 16•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/36730ac6b59f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•