[RTL] RTL the preferences in about:config

RESOLVED FIXED in Firefox 54

Status

()

Firefox for Android
Theme and Visual Design
P5
normal
RESOLVED FIXED
9 months ago
4 months ago

People

(Reporter: ItielMaN, Assigned: tomer)

Tracking

(Depends on: 1 bug, Blocks: 1 bug, {rtl})

Trunk
Firefox 54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

9 months ago
Current RTL builds have the preferences in about:config in the left side of the page.
Firefox should display each preference (and its value, too!) in the right side of the page, but in a way that the text itself will stay in LTR formation, to avoid possible preferences (or values) like "this_is_an_example_" to appear as "_this_is_an_example".

Screenshot of current look of about:config in RTL build can be seen in bug 1298904.
(Reporter)

Comment 1

6 months ago
Still an issue on latest Nightly builds.
(Assignee)

Updated

6 months ago
Assignee: nobody → tomer.moz.bugs
(Assignee)

Comment 2

6 months ago
I am not sure how important it is, but dir=auto might be more appropriate here than ltr/rtl.
(Reporter)

Updated

5 months ago
Version: 48 Branch → unspecified

Comment 3

4 months ago
Max is this something we can do/control depending on the framework/build?
Flags: needinfo?(max)
OS: Android → All
QA Contact: ioana.chiorean
Hardware: Unspecified → All
Version: unspecified → Trunk
Blocks: 1319302

Comment 4

4 months ago
(In reply to Ioana Chiorean from comment #3)
> Max is this something we can do/control depending on the framework/build?

I think about:config is not for normal end user. This bug might still need to be fixed but should not block 53 release schedule.
Flags: needinfo?(max)
(Assignee)

Comment 5

4 months ago
Created attachment 8828431 [details]
Screenshot

I am summarizing a discussion we held offline: 

1. Keys should always be with dir=ltr.
2. We can live with setting values to dir=ltr as well, but it will cause problems in case there is a value in non-ltr characters, so dir=auto will be more appropriate here. (so we won't end up with strings such as "!test" instead of "test!".
Flags: needinfo?(itiel_yn8)
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Depends on: 1332396
(Reporter)

Comment 7

4 months ago
(In reply to Tomer Cohen :tomer from comment #5)
> Created attachment 8828431 [details]
> Screenshot
> 
> I am summarizing a discussion we held offline: 
> 
> 1. Keys should always be with dir=ltr.
> 2. We can live with setting values to dir=ltr as well, but it will cause
> problems in case there is a value in non-ltr characters, so dir=auto will be
> more appropriate here. (so we won't end up with strings such as "!test"
> instead of "test!".

Agreed, plus we also have:
3. The separators between each pref should appear from side to side. Currently it's cut off at some point. See attachment 8828431 [details].
Flags: needinfo?(itiel_yn8)
(Assignee)

Updated

4 months ago
See Also: → bug 1325230
(Assignee)

Comment 8

4 months ago
Created attachment 8828487 [details]
Screenshot (wip; after resolving issues #1 and #2)

(In reply to ItielMaN from comment #7)
> 3. The separators between each pref should appear from side to side.
> Currently it's cut off at some point. See attachment 8828431 [details].
It is not just the separators, but there is a right margin on the page, which also makes the space for keys shorter in RTL than LTR.
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Attachment #8828432 - Flags: review?(s.kaspari)

Comment 10

4 months ago
mozreview-review
Comment on attachment 8828432 [details]
Bug 1298913 - [RTL] RTL the preferences in about:config

https://reviewboard.mozilla.org/r/105844/#review107938
Attachment #8828432 - Flags: review?(s.kaspari) → review+
(Assignee)

Updated

4 months ago
Keywords: checkin-needed

Comment 11

4 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/958d5fbbabbf
[RTL] RTL the preferences in about:config r=sebastian
Keywords: checkin-needed

Comment 12

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/958d5fbbabbf
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.