Closed
Bug 1298913
Opened 8 years ago
Closed 8 years ago
[RTL] RTL the preferences in about:config
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect, P5)
Firefox for Android Graveyard
Theme and Visual Design
Tracking
(firefox54 fixed)
RESOLVED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: itiel_yn8, Assigned: tomer)
References
Details
(Keywords: rtl)
Attachments
(3 files)
Current RTL builds have the preferences in about:config in the left side of the page.
Firefox should display each preference (and its value, too!) in the right side of the page, but in a way that the text itself will stay in LTR formation, to avoid possible preferences (or values) like "this_is_an_example_" to appear as "_this_is_an_example".
Screenshot of current look of about:config in RTL build can be seen in bug 1298904.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → tomer.moz.bugs
Assignee | ||
Comment 2•8 years ago
|
||
I am not sure how important it is, but dir=auto might be more appropriate here than ltr/rtl.
Comment 3•8 years ago
|
||
Max is this something we can do/control depending on the framework/build?
Flags: needinfo?(max)
OS: Android → All
QA Contact: ioana.chiorean
Hardware: Unspecified → All
Version: unspecified → Trunk
Comment 4•8 years ago
|
||
(In reply to Ioana Chiorean from comment #3)
> Max is this something we can do/control depending on the framework/build?
I think about:config is not for normal end user. This bug might still need to be fixed but should not block 53 release schedule.
Flags: needinfo?(max)
Assignee | ||
Comment 5•8 years ago
|
||
I am summarizing a discussion we held offline:
1. Keys should always be with dir=ltr.
2. We can live with setting values to dir=ltr as well, but it will cause problems in case there is a value in non-ltr characters, so dir=auto will be more appropriate here. (so we won't end up with strings such as "!test" instead of "test!".
Flags: needinfo?(itiel_yn8)
Comment hidden (mozreview-request) |
(In reply to Tomer Cohen :tomer from comment #5)
> Created attachment 8828431 [details]
> Screenshot
>
> I am summarizing a discussion we held offline:
>
> 1. Keys should always be with dir=ltr.
> 2. We can live with setting values to dir=ltr as well, but it will cause
> problems in case there is a value in non-ltr characters, so dir=auto will be
> more appropriate here. (so we won't end up with strings such as "!test"
> instead of "test!".
Agreed, plus we also have:
3. The separators between each pref should appear from side to side. Currently it's cut off at some point. See attachment 8828431 [details].
Flags: needinfo?(itiel_yn8)
Assignee | ||
Comment 8•8 years ago
|
||
(In reply to ItielMaN from comment #7)
> 3. The separators between each pref should appear from side to side.
> Currently it's cut off at some point. See attachment 8828431 [details].
It is not just the separators, but there is a right margin on the page, which also makes the space for keys shorter in RTL than LTR.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8828432 -
Flags: review?(s.kaspari)
Comment 10•8 years ago
|
||
mozreview-review |
Comment on attachment 8828432 [details]
Bug 1298913 - [RTL] RTL the preferences in about:config
https://reviewboard.mozilla.org/r/105844/#review107938
Attachment #8828432 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 11•8 years ago
|
||
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/958d5fbbabbf
[RTL] RTL the preferences in about:config r=sebastian
Keywords: checkin-needed
Comment 12•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•