1298913 - [RTL] RTL the preferences in about:config

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P5)

Description

[Itiel]

Current RTL builds have the preferences in about:config in the left side of the page.
Firefox should display each preference (and its value, too!) in the right side of the page, but in a way that the text itself will stay in LTR formation, to avoid possible preferences (or values) like "this_is_an_example_" to appear as "_this_is_an_example".

Screenshot of current look of about:config in RTL build can be seen in bug 1298904.

Comment 1

[Itiel]

Still an issue on latest Nightly builds.

Comment 2

[Tomer Cohen :tomer]

I am not sure how important it is, but dir=auto might be more appropriate here than ltr/rtl.

Comment 3

[Ioana Chiorean]

Max is this something we can do/control depending on the framework/build?

Comment 4

[Max Liu [:maliu]]

(In reply to Ioana Chiorean from comment #3)
> Max is this something we can do/control depending on the framework/build?

I think about:config is not for normal end user. This bug might still need to be fixed but should not block 53 release schedule.

Comment 5

[Tomer Cohen :tomer]

Attachment: Screenshot

I am summarizing a discussion we held offline: 

1. Keys should always be with dir=ltr.
2. We can live with setting values to dir=ltr as well, but it will cause problems in case there is a value in non-ltr characters, so dir=auto will be more appropriate here. (so we won't end up with strings such as "!test" instead of "test!".

Comment 6

[Tomer Cohen :tomer]

Attachment: Bug 1298913 - [RTL] RTL the preferences in about:config

Review commit: https://reviewboard.mozilla.org/r/105844/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105844/

Comment 7

[Itiel]

(In reply to Tomer Cohen :tomer from comment #5)
> Created attachment 8828431 [details]
> Screenshot
> 
> I am summarizing a discussion we held offline: 
> 
> 1. Keys should always be with dir=ltr.
> 2. We can live with setting values to dir=ltr as well, but it will cause
> problems in case there is a value in non-ltr characters, so dir=auto will be
> more appropriate here. (so we won't end up with strings such as "!test"
> instead of "test!".

Agreed, plus we also have:
3. The separators between each pref should appear from side to side. Currently it's cut off at some point. See attachment 8828431 [details].

Comment 8

[Tomer Cohen :tomer]

Attachment: Screenshot (wip; after resolving issues #1 and #2)

(In reply to ItielMaN from comment #7)
> 3. The separators between each pref should appear from side to side.
> Currently it's cut off at some point. See attachment 8828431 [details].
It is not just the separators, but there is a right margin on the page, which also makes the space for keys shorter in RTL than LTR.

Comment 9

[Tomer Cohen :tomer]

Comment on attachment 8828432 [details]
Bug 1298913 - [RTL] RTL the preferences in about:config

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105844/diff/1-2/

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8828432 [details]
Bug 1298913 - [RTL] RTL the preferences in about:config

https://reviewboard.mozilla.org/r/105844/#review107938

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/958d5fbbabbf
[RTL] RTL the preferences in about:config r=sebastian

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/958d5fbbabbf