Closed
Bug 1299003
Opened 9 years ago
Closed 9 years ago
Selection handles appear intermittently when resizing
Categories
(DevTools :: Responsive Design Mode, defect)
DevTools
Responsive Design Mode
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: jryans, Assigned: jryans)
Details
Attachments
(2 files)
rdm-selection-arrows.png
Similar issue to bug 1294841, but a bit more general.
STR:
1. Open new RDM
2. Resize the viewport by dragging the corner gripper
* You may need to use a touchpad and / or make aggressive motions to trigger
ER:
No selection arrows
AR:
In some cases, bits on the dimension entry UI get selection arrows.
Overall, we don't want these selection arrows in most cases. Only bits of text in things like inputs would make sense to me.
Flags: qe-verify-
| Comment hidden (mozreview-request) |
|
||
Updated•9 years ago
|
Iteration: --- → 51.3 - Sep 12
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8786155 [details]
Bug 1299003 - Remove selection arrows from structural RDM UI.
Not sure about :ntim's availability. :bgrins should be able to review as well.
Attachment #8786155 -
Flags: review?(bgrinstead)
|
||
Comment 3•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8786155 [details]
Bug 1299003 - Remove selection arrows from structural RDM UI.
https://reviewboard.mozilla.org/r/75120/#review73628
By "selection arrows", do you mean the cursor that shows up when you hover text? In my testing, setting user-select: none doesn't prevent that UI (data:text/html,<body><p style="-moz-user-select:none">test</p></body>) but setting cursor:default does (data:text/html,<body><p style="cursor:default">test</p></body>)
|
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #3)
> Comment on attachment 8786155 [details]
> Bug 1299003 - Remove selection arrows from structural RDM UI.
>
> https://reviewboard.mozilla.org/r/75120/#review73628
>
> By "selection arrows", do you mean the cursor that shows up when you hover
> text? In my testing, setting user-select: none doesn't prevent that UI
> (data:text/html,<body><p style="-moz-user-select:none">test</p></body>) but
> setting cursor:default does (data:text/html,<body><p
> style="cursor:default">test</p></body>)
No, I mean these blue start and end selection markers... The odd thing is that I don't see them appear elsewhere on desktop Firefox... I don't really follow what it is about RDM that is triggering them to appear at all.
|
|
Assignee | |
Comment 5•9 years ago
|
||
Hmm... I don't think I see them on a new profile, only on my dev profile. Do you get them at all in RDM?
|
|
||
Comment 6•9 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5)
> Hmm... I don't think I see them on a new profile, only on my dev profile.
> Do you get them at all in RDM?
That's weird, I've never seen those selection arrows on desktop before. I tried resizing vigorously and couldn't repro locally.
|
|
Assignee | |
Comment 7•9 years ago
|
||
Comment on attachment 8786155 [details]
Bug 1299003 - Remove selection arrows from structural RDM UI.
Okay, I'll cancel reviews for now. I guess I should figure out what's triggering it first.
Thanks for trying it out!
Attachment #8786155 -
Flags: review?(ntim.bugs)
Attachment #8786155 -
Flags: review?(bgrinstead)
|
||
Comment 8•9 years ago
|
||
Sorry for the lag, I was on a plane. I can't see the selection arrows from comment 4 on my device. Probably some b2g related pref you have enabled? Or could be related to the touch simulator?
|
|
Assignee | |
Comment 9•9 years ago
|
||
:kats helped me spot the issue on IRC. In Nightly only, we draw a selection caret if the selection comes from a touch event. Touch events are off by default, at least for macOS. My dev profile had toggled "dom.w3c_touch_events.enabled" to "1" which forced them on, triggering the selection carets. (Most likely this was set by the touch simulation from old RDM which applied to all tabs.)
You can see the current state[1] of the pref defaults. It's enabled by default for Linux, and it will be for Windows soonish. For those platforms it will be set to "2", which means "touch events enabled only if a touch device is present".
So, it sounds like you would only get the carets (in a shipping configuration) if you touch a screen with touch support, which seems unlikely...?
I think I'll close this until there's a clear user issue in a shipping config.
[1]: https://dxr.mozilla.org/mozilla-central/rev/506facea63169a29e04eb140663da1730052db64/modules/libpref/init/all.js#4788
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
|
|
||
Updated•9 years ago
|
Iteration: 51.3 - Sep 12 → ---
Priority: P1 → --
Whiteboard: [multiviewport][reserve-rdm]
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•