129908 - [PATCH]Partially decoded background images should not be painted

Status: VERIFIED FIXED

(Core Graveyard :: GFX, defect, P1)

Description

[Kevin McCluskey (gone)]

Since we do not incrementally display background images as image data arrives we
should not display partially decoded background images when painting damaged
areas,  We should wait until they are fully loaded before painting them.

Expected:
If you move a window over the browser while it is loading a page with a
background image it should not display the background image.

What happens:
If you move a window over the browser while it is loading a page with a
background image it displays the partially decoded background image in the
locations where the window was moved over the browser.

Comment 1

[Kevin McCluskey (gone)]

Attachment: test case which loads a large background image

Move a window over the top of the browser window while it loads the test case
and you will see a partially decoded image in the locations where you have
moved the window over the browser window.

Comment 2

[Kevin McCluskey (gone)]

Attachment: Patch which prevents partially decoded background images from being painted

Comment 3

[Kevin McCluskey (gone)]

The patch seems like the obvious fix but it does not work correctly. The
background image is not displayed. the LOAD_COMPLETE status must be set after
the paint is processed as the result of the OnStopFrame in nsImageLoader?

Comment 4

[Stuart Parmenter]

LOAD_COMPLETE is set after OnStopDecode.  from a quick glance over the code, it 
looks like it could be set before the call to OnStopDecode, but I will have to 
investigate further.

Comment 5

[Kevin McCluskey (gone)]

Attachment: Patch which adds a new STATUS_FRAME_COMPLETE flag for the image request and checks for this flag before painting background images

Instead of changing where STATUS_LOAD_COMPLETE is set I added a new
STATUS_FRAME_COMPLETE flag which gets set before calling OnStopFrame. I think
it may be too risky to change anything having to do with STATUS_LOAD_COMPLETE
so close to Mozilla1.0.

Comment 6

[Kevin McCluskey (gone)]

nsbeta1+. Very visible defect on a large number of sites.

Comment 7

[Marc Attinasi]

Comment on attachment 75331 [details] [diff] [review]
Patch which adds a new STATUS_FRAME_COMPLETE flag for the image request and checks for this flag before painting background images

sr=attinasi

Comment 8

[Stuart Parmenter]

Comment on attachment 75331 [details] [diff] [review]
Patch which adds a new STATUS_FRAME_COMPLETE flag for the image request and checks for this flag before painting background images

r=pavlov

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 75331 [details] [diff] [review]
Patch which adds a new STATUS_FRAME_COMPLETE flag for the image request and checks for this flag before painting background images

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 10

[Kevin McCluskey (gone)]

Checked patch into trunk.

Comment 11

[Kevin McCluskey (gone)]

*** Bug 132473 has been marked as a duplicate of this bug. ***

Comment 12

[Chris Petersen]

Marking verified in the April 23rd trunk OS X (2002-04-23-08) and Windows ME
(2002-04-23-06) builds