1299130 - Don't build docker image on every push

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

We unfortunately have to implement caching ourselves, the decision task needs to check whether a task for the given context hash exists and completed successfully, and then point to that task id.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Here's the first run with the task indexed:

https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=169f95b53526e5cbe4680f70025803b76432ce9a

Here's the second picking up the docker image of the first:

https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=4998580195dc67e991aa1e8b37b9ce871c991f3c

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1299130-Don-t-build-docker-image-on-every-push.patch

This checks with the TC API first if there's a docker image, and if so uses it without adding a new image builder task. In case of any failure it falls back to simply adding a task.

Comment 3

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8786724 [details] [diff] [review]
0001-Bug-1299130-Don-t-build-docker-image-on-every-push.patch

Review of attachment 8786724 [details] [diff] [review]:
-----------------------------------------------------------------

::: automation/taskcluster/graph/image_builder.js
@@ +74,5 @@
>    return task;
>  }
>  
> +// Returns a Promise<bool> that tells whether the task with the given id
> +// has an public/image.tar artifact with a ready-to-use docker image.

a public

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/projects/nss/rev/a5c92cd8a0f0