1299172 - Intermittent dom/media/test/test_bug879717.html | application crashed [@ mozilla::MediaStreamGraph::DispatchToMainThreadAfterStreamStateUpdate(already_AddRefed<nsIRunnable>)]

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: rvandermeulen [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=4790008&repo=mozilla-central

https://archive.mozilla.org/pub/firefox/nightly/2016/08/2016-08-30-03-02-01-mozilla-central/mozilla-central_xp_ix_test_pgo-mochitest-media-bm109-tests1-windows-build9.txt.gz

Not sure if related to bug 1298312 or not.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

DispatchToMainThreadAfteStreamStateUpdate() is being called from NotifyRealtimeTrackData in the HTML media element's StreamSizeListener

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1299172 - Assert on MSG thread in DispatchToMainThreadAfterStreamStateUpdate.

Review commit: https://reviewboard.mozilla.org/r/75640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75640/

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1299172 - Fix media element StreamSizeListener calling DispatchToMainThreadAfterStreamStateUpdate off-MSG-thread.

Review commit: https://reviewboard.mozilla.org/r/75642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75642/

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1299172 - HTMLMediaElement::StreamSizeListener spring cleaning.

Review commit: https://reviewboard.mozilla.org/r/75644/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75644/

Comment 5

[Andreas Pehrson [:pehrsons]]

Aurora-try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d221a032d50c

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8786715 [details]
Bug 1299172 - Assert on MSG thread in DispatchToMainThreadAfterStreamStateUpdate.

https://reviewboard.mozilla.org/r/75640/#review73548

I'll note that the assertion is slightly broader than the requirements of DispatchToMainThreadAfterState...() - but that's probably OK.  We could make the name yet-more-unwieldy (AssertOnGraphThreadOrNotRunningOrLocked()) ;-)

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8786716 [details]
Bug 1299172 - Fix media element StreamSizeListener calling DispatchToMainThreadAfterStreamStateUpdate off-MSG-thread.

https://reviewboard.mozilla.org/r/75642/#review73552

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8786717 [details]
Bug 1299172 - HTMLMediaElement::StreamSizeListener spring cleaning.

https://reviewboard.mozilla.org/r/75644/#review73554

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1607565e9d8
Assert on MSG thread in DispatchToMainThreadAfterStreamStateUpdate. r=jesup
https://hg.mozilla.org/integration/autoland/rev/984aa37067f0
Fix media element StreamSizeListener calling DispatchToMainThreadAfterStreamStateUpdate off-MSG-thread. r=jesup
https://hg.mozilla.org/integration/autoland/rev/aa5325ca0e18
HTMLMediaElement::StreamSizeListener spring cleaning. r=jesup

Comment 10

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8786716 [details]
Bug 1299172 - Fix media element StreamSizeListener calling DispatchToMainThreadAfterStreamStateUpdate off-MSG-thread.

Approval Request Comment
[Feature/regressing bug #]: bug 1266646
[User impact if declined]: Crashes, rather rare, when playing a MediaStream in a media element.
[Describe test coverage new/current, TreeHerder]: Multiple intermittents in automation getting fixed by this
[Risks and why]: Low risk. Not changing any logic, just on which thread it runs (which could cause event reordering but in this particular case I believe it doesn't matter).
[String/UUID change made/needed]: None

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b1607565e9d8
https://hg.mozilla.org/mozilla-central/rev/984aa37067f0
https://hg.mozilla.org/mozilla-central/rev/aa5325ca0e18

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hello Wes, Ryan, can one of you please confirm that this intermittent is gone from Nightly? I can then approve the uplift to Aurora. Thanks!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

None of the failures associated with this bug have occurred on trunk branches since these patches hit them. LGTM!

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8786716 [details]
Bug 1299172 - Fix media element StreamSizeListener calling DispatchToMainThreadAfterStreamStateUpdate off-MSG-thread.

fixes an intermittent, verified on nightly (Thanks Ryan!), Aurora50+

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c234a6308024
https://hg.mozilla.org/releases/mozilla-aurora/rev/fb3d52cace0f
https://hg.mozilla.org/releases/mozilla-aurora/rev/47a382f66030