Closed Bug 1299213 Opened 8 years ago Closed 8 years ago

Clean up ui/* now that no submodule is used

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jlorenzo, Assigned: jlorenzo)

References

Details

Attachments

(1 file, 1 obsolete file)

PR
42 bytes, text/x-github-pull-request
bhearsum
: review+
Details | Review 
Thanks to the docker image, we don't really need the balrog-ui repo to store the result of minimification. We can get rid of it because it's subject to whatever people commit.
Assignee: nobody → jlorenzo
Attached file PR — 

        Attachment #8786649 -
        Flags: review?(bhearsum)

    
    

    
  

      
      
      
      

        Attached file
          
        balrog-ui PR (obsolete)
        — 
      

    


  

        Attachment #8786650 -
        Flags: review?(bhearsum)

    
  
Status: NEW → ASSIGNED

    
    

    
  
Tests are failing because we don't init the submodule first. This won't be necessary anymore once bug 1299203 lands. Clearing reviews for now.
Depends on: 1299203

    
  

        Attachment #8786649 -
        Flags: review?(bhearsum)

    
  

        Attachment #8786650 -
        Flags: review?(bhearsum)

    
  
Summary: Make docker image build front-end → Clean up ui/* now that no submodule is used

    
  

        Attachment #8786650 -
        Attachment is obsolete: true

    
    

    
  
Half of the build part was done in bug 1299203. Renaming the bug to extend the scope of the patch.

    
  

        Attachment #8786649 -
        Attachment description: balrog PR (should land first) → PR

    
    

    
  
Comment on attachment 8786649 [details] [review]
PR

Dev builds are done at each `docker-compose up`. Tests are split into front-end and back-end. Extra config file in ui/* have been merged to their equivalents at the root folder. Do you see anything else we could change?

        Attachment #8786649 -
        Flags: review?(bhearsum)

        Attachment #8786649 -
        Flags: review?(bhearsum) → review+

    
    

    
  
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/ecdf83e079af1f91ee5520c12a434f73db001191
Bug 1299213 - Clean up ui/* now that no submodule is used (#115). r=bhearsum

    
    

    
  
https://github.com/mozilla/balrog/commit/ecdf83e079af1f91ee5520c12a434f73db001191
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED

    
  
Product: Release Engineering → Release Engineering Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: