1299373 - Don't execute scripts with src=""

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Per spec these should fire error and not execute.  That's what Safari and Chrome seem to do, at least.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Scripts with an empty src attribute should not execute

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Scripts with an empty src attribute should not execute

Comment 3

[Boris Zbarsky [:bzbarsky]]

Anne, Ben noticed an interesting issue while reviewing this patch.  I had stopped using GetSrc because it doesn't return "" when the attr value is "" in Gecko.  Per the spec, I _think_ this case should fall into the "If a reflecting IDL attribute is a USVString attribute whose content attribute is defined to contain a URL and is also required to contain a valid non-empty URL potentially surrounded by spaces" case and hence return "" if the attr value is "", right?  But I don't see any browsers doing that.  Gecko/Blink/WebKit all return the base URI; Edge returns the base URI with everything after the last '/' stripped off.  Testcase at http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=4429

Do you happen to know whether other engines are planning to align with the spec here or what the story is?

Comment 4

[Anne (:annevk)]

The substeps of step 18 at https://html.spec.whatwg.org/#prepare-a-script do not use the src IDL attribute. They talk about the src content attribute. So you want the equivalent of getAttributeNS(null, "src") I'd say.

Comment 5

[Anne (:annevk)]

Okay, I see now you're asking a question unrelated to OP. Simon looked into reflect a while back. I'm not sure if he covered this particular case, but that does seem like something that should maybe be changed.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> Okay, I see now you're asking a question unrelated to OP.

Not entirely.  If the src IDL attribute actually behaved as currently specced, we _could_ use it in step 18.  That's the relationship.

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8786645 [details] [diff] [review]
Scripts with an empty src attribute should not execute

Dropping this for now until we have a plan.

Comment 8

[Boris Zbarsky [:bzbarsky]]

OK, filed https://github.com/whatwg/html/issues/1739 on the spec so I can move on here.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Scripts with an empty src attribute should not execute

Comment 10

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8787790 [details] [diff] [review]
Scripts with an empty src attribute should not execute

Review of attachment 8787790 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 11

[Boris Zbarsky [:bzbarsky]]

Note that the spec has being reverted to have .src return something other than "" in this situation; I'll update the comment accordingly.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8edc64f3a6e4
Scripts with an empty src attribute should not execute.  r=bkelly

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8edc64f3a6e4