1299450 - "this.client is undefined" error is thrown in the console when dragging a tab for the second time in a new window while the RDM is enabled

Status: NEW

(DevTools :: Responsive Design Mode, defect, P3)

Description

[Mihai Boldan, Desktop QA [:mboldan]]

[Note]:
- Logged based on Bug 1274084 Comment 3

[Affected versions]:
- Firefox 51.0a1(51.0a1 (2016-08-30))

[Affected platforms]:
- Windows 10x64, Mac OS X 10.10.5, Ubuntu 16.04x64

[Steps to reproduce]:
1. Launch Firefox.
2. From about:config, enable the devtools.responsive.html.enabled pref.
3. Enable RDM.
4. Enable Browser Console.
5. Drag the tab in order to open it in a new window.
6. Open a new tab in the new window.
7. Enable RDM.
8. Drag the tab in order to open it in a new window and observe the Browser Console.

[Expected result]:
- No error is thrown in the console.

[Actual result]:
- TypeError: this.client is undefined[Learn More]manager.js:379:7 is thrown in the console.

[Regression range]:
- I will verify ASAP if this is a regression.

Comment 1

[Kamil Jozwiak [:kjozwiak]]

STR using a debug version of m-c:

* launch the latest version of m-c
* open another tab and visit mozilla.org (should have two tabs opened)
* place the mozilla.org tab into RDM via the keyboard shortcut
* move the mozilla.org tab that's currently in RDM into it's own separate window
* place the new mozilla.org window back into RDM
* move the mozilla.org tab that's currently in RDM back into the original window

*************************
A coding exception was thrown and uncaught in a Task.

Full message: TypeError: this.client is undefined
Full stack: ResponsiveUI.prototype.destroy<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/responsive.html/manager.js:385:9
TaskImpl.prototype._run@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:311:39
TaskImpl@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:273:3
createAsyncFunction/asyncFunction@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:247:14
exports.ResponsiveUIManager.closeIfNeeded<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/responsive.html/manager.js:109:29
TaskImpl.prototype._run@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:311:39
TaskImpl@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:273:3
createAsyncFunction/asyncFunction@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:247:14
handleEvent@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/responsive.html/manager.js:422:9
_beginRemoveTab@chrome://browser/content/tabbrowser.xml:2496:13
swapBrowsersAndCloseOther@chrome://browser/content/tabbrowser.xml:2726:18
gBrowserInit._delayedStartup@chrome://browser/content/browser.js:1122:11
EventListener.handleEvent*gBrowserInit.onLoad@chrome://browser/content/browser.js:1020:5
onload@chrome://browser/content/browser.xul:1:1

*************************
[Parent 36647] WARNING: Swapping remote and non-remote frames is not currently supported: file /Users/kjozwiak/projects/m-c/dom/base/nsFrameLoader.cpp, line 1173

Comment 2

[Mihai Boldan, Desktop QA [:mboldan]]

Here is the result found with mozregression:
Last good revision: 2d4a3ed753407f210a3a0268691e1be38280420a
First bad revision: 7d3bc3efebe0730a8f8d560ca5c07eb2501d74ad
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2d4a3ed753407f210a3a0268691e1be38280420a&tochange=7d3bc3efebe0730a8f8d560ca5c07eb2501d74ad

Taking in consideration that the FF crashes on the previous builds when opening the current tab in a new window using drag&drop, my opinion is that this issue is not a regression.